You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Age Mooy <am...@home.nl> on 2002/07/10 23:10:51 UTC
RE: please resend patches ([PATCH] ParameterParser copy-paste error ?)
Hi,
I found the following two methods in the org.apache.turbine.util.ParameterParser interface
- public void setUploadData ( byte[] uploadData );
- public byte[] setUploadData ();
Either the second method has a very non-standard name for a getter or someone made a typo. I found the same
setUploadData() method in org.apache.turbine.util.parser.DefaultParameterParser.
I couldn't find any references to these methods in the rest of the turbine-2 src so that might be why this was
never noticed.
In case this was not intentional, I attached a text file with the two patches,
Age
Re: please resend patches ([PATCH] ParameterParser copy-paste error
?)
Posted by Martin Poeschl <mp...@marmot.at>.
Age Mooy wrote:
> Hi,
>
> I found the following two methods in the org.apache.turbine.util.ParameterParser interface
>
> - public void setUploadData ( byte[] uploadData );
> - public byte[] setUploadData ();
>
> Either the second method has a very non-standard name for a getter or someone made a typo. I found the same
> setUploadData() method in org.apache.turbine.util.parser.DefaultParameterParser.
>
> I couldn't find any references to these methods in the rest of the turbine-2 src so that might be why this was
> never noticed.
>
> In case this was not intentional, I attached a text file with the two patches,
> Age
done
>
>
>
> ------------------------------------------------------------------------
>
>
>
> Index: ParameterParser.java
> ===================================================================
> RCS file: /home/cvspublic/jakarta-turbine-2/src/java/org/apache/turbine/util/ParameterParser.java,v
> retrieving revision 1.2
> diff -u -r1.2 ParameterParser.java
> --- ParameterParser.java 9 Sep 2001 01:31:29 -0000 1.2
> +++ ParameterParser.java 24 Jun 2002 09:17:42 -0000
> @@ -118,7 +118,7 @@
> *
> * @return uploadData A byte[] with data.
> */
> - public byte[] setUploadData ();
> + public byte[] getUploadData ();
>
>
> /**
>
>
>
>
> Index: DefaultParameterParser.java
> ===================================================================
> RCS file: /home/cvspublic/jakarta-turbine-2/src/java/org/apache/turbine/util/parser/DefaultParameterParser.java,v
> retrieving revision 1.3
> diff -u -r1.3 DefaultParameterParser.java
> --- DefaultParameterParser.java 15 Mar 2002 12:50:17 -0000 1.3
> +++ DefaultParameterParser.java 24 Jun 2002 09:18:00 -0000
> @@ -255,7 +255,7 @@
> *
> * @return uploadData A byte[] with data.
> */
> - public byte[] setUploadData ()
> + public byte[] getUploadData ()
> {
> return this.uploadData;
> }
>
>
>
>
> ------------------------------------------------------------------------
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>