You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Syed Ahmed <sa...@cloudops.com> on 2014/11/01 15:26:21 UTC
Review Request 27464: Remove private key from listSslCerts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27464/
-----------------------------------------------------------
Review request for cloudstack and Will Stevens.
Repository: cloudstack-git
Description
-------
Remove private key from listSslCerts
Diffs
-----
api/src/org/apache/cloudstack/api/response/SslCertResponse.java 67011f9
server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 695b935
Diff: https://reviews.apache.org/r/27464/diff/
Testing
-------
Thanks,
Syed Ahmed
Re: Review Request 27464: Remove private key from listSslCerts
Posted by Will Stevens <ws...@cloudops.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27464/#review62145
-----------------------------------------------------------
Ship it!
Ship It!
- Will Stevens
On Nov. 1, 2014, 2:26 p.m., Syed Ahmed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27464/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 2:26 p.m.)
>
>
> Review request for cloudstack and Will Stevens.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Remove private key from listSslCerts
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/response/SslCertResponse.java 67011f9
> server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 695b935
>
> Diff: https://reviews.apache.org/r/27464/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Syed Ahmed
>
>
Re: Review Request 27464: Remove private key from listSslCerts
Posted by Will Stevens <ws...@cloudops.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27464/#review62144
-----------------------------------------------------------
Ship it!
I have tested this change on master this morning and everything works as expected... Ship It!
- Will Stevens
On Nov. 1, 2014, 2:26 p.m., Syed Ahmed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27464/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 2:26 p.m.)
>
>
> Review request for cloudstack and Will Stevens.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Remove private key from listSslCerts
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/response/SslCertResponse.java 67011f9
> server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 695b935
>
> Diff: https://reviews.apache.org/r/27464/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Syed Ahmed
>
>