You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by GitBox <gi...@apache.org> on 2021/09/20 16:34:50 UTC

[GitHub] [atlas] ashutoshm commented on a change in pull request #142: ATLAS-4358 move addition of default java patches to applyAll method

ashutoshm commented on a change in pull request #142:
URL: https://github.com/apache/atlas/pull/142#discussion_r712333857



##########
File path: repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
##########
@@ -48,28 +48,24 @@ public AtlasPatchManager(AtlasGraph atlasGraph, AtlasTypeRegistry typeRegistry,
         this.context = new PatchContext(atlasGraph, typeRegistry, indexer, entityGraphMapper);
     }
 
-    @PostConstruct

Review comment:
       This approach is fine. However, i would keep the init method in tact and just remove the @PostConstruct annotation.
   
   Call _init_ in the _applyAll_ method.
   
   I verified this change and it is fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org