You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/09/06 12:09:24 UTC

Re: Review Request 60765: Added basic `network/ports` isolator tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60765/#review184652
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/ports_isolator_tests.cpp
Lines 482-483 (patched)
<https://reviews.apache.org/r/60765/#comment260842>

    I do not think we need `Resources(`, just `resources = Resources::parse(` should be OK.


- Qian Zhang


On July 29, 2017, 8:02 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60765/
> -----------------------------------------------------------
> 
> (Updated July 29, 2017, 8:02 a.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests to verify that the `network/ports` is able to correctly
> terminate only tasks that use rogue TCP ports.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60765/diff/13/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>