You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/08 22:58:57 UTC
[GitHub] [incubator-tvm] junrushao1994 opened a new pull request #6425: [Minor] Fix typos in Ansor
junrushao1994 opened a new pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425
Recently I installed a spell checker in VSCode...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-689355381
Let's wait for a few days before merging this PR, as I found some typos leftover
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-692488896
Should be good to go :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-691171694
@junrushao1994 please rebase and address @leandron 's comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on a change in pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#discussion_r485511709
##########
File path: src/auto_scheduler/search_policy/utils.h
##########
@@ -645,11 +645,11 @@ class SplitFactorizationMemo {
std::unordered_map<int, std::vector<int>> factor_memory_;
};
-/*! \brief Get the indexes of SplitStep that processes on spatial iteratior. */
+/*! \brief Get the indexes of SplitStep that processes on spatial iterator. */
Array<Integer> GetSpatialSplitStepIds(const State& s, int stage_id);
// Apply multi-level tiling structure according to a string format,
-// where "S" stands a space level, "R" stands for a reudciton level.
+// where "S" stands a space level, "R" stands for a reduction level.
// For example, if the format is "SSRSRS", the we will
Review comment:
```suggestion
// For example, if the format is "SSRSRS", then we will
```
##########
File path: include/tvm/auto_scheduler/compute_dag.h
##########
@@ -99,7 +99,7 @@ class AccessAnalyzer : public ObjectRef {
/*!
* \brief Return whether this operation is strictly inlinable
Review comment:
```suggestion
* \brief Return whether this operation is strictly inlineable
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-693050210
Thanks @junrushao1994 @leandron @jcf94 @electriclilies !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-690927401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-689846732
@junrushao1994 please incorporate @leandron 's comment then we can merge it in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-691171694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-693027008
@tqchen @jcf94 Could you take another look? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-690927401
should wait for #6448 before landing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-690927401
should wait for #6448 before landing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6425: [Minor] Fix typos in Ansor
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6425:
URL: https://github.com/apache/incubator-tvm/pull/6425#issuecomment-691171694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org