You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "mridulpathak (via GitHub)" <gi...@apache.org> on 2026/09/16 06:59:54 UTC

[PR] Fixed: Four regressions in the minilang-to-Groovy conversion of PartyServicesScript.groovy (OFBIZ-13593) [ofbiz-framework]

mridulpathak opened a new pull request, #2017:
URL: https://github.com/apache/ofbiz-framework/pull/2017

   - followPartyRelationshipsInlineRecurse read a nonexistent partyRel.partyFrom field (the actual field is partyIdFrom) in the includeFromToSwitched=='Y' branch, throwing IllegalArgumentException; reachable via getParentOrganizations
   - getChildRoleTypes returned only the discovered child role types, omitting the original seed roleTypeId; the other two callers of getChildRoleTypesInline already prepend the seed, and the service's own description states the result "will contain the original roleTypeId"
   - getPartiesByRelationship used lookupMap.setAllFields(parameters, false, null, null), which includes any of fromDate/thruDate/relationshipName the caller happens to pass (they're valid optional IN params per the servicedef), producing narrower result sets than the original minilang, which explicitly copied only partyIdFrom, partyIdTo, roleTypeIdFrom, roleTypeIdTo, statusId, priorityTypeId, and partyRelationshipTypeId
   - getPartyNameForDate reassigns person to the matching PartyNameHistory record when a historical name change applies, then gates the gender result on !partyNameHistoryCurrent - a condition that's always false whenever that reassignment happened, silently dropping gender (PartyNameHistory has no gender field of its own); gender is now captured from the original Person record before the reassignment and always used
   
   Each fix was verified against the original minilang and covered by a temporary RED/GREEN test before removal, and the party component's test suite passes unchanged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fixed: Four regressions in the minilang-to-Groovy conversion of PartyServicesScript.groovy (OFBIZ-13593) [ofbiz-framework]

Posted by "mridulpathak (via GitHub)" <gi...@apache.org>.
mridulpathak merged PR #2017:
URL: https://github.com/apache/ofbiz-framework/pull/2017


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org