[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #880: Close snapshot form in case of an error

[GitBox <gi...@apache.org>]

Pearl1594 commented on a change in pull request #880:
URL: https://github.com/apache/cloudstack-primate/pull/880#discussion_r534062127



##########
File path: src/views/storage/TakeSnapshot.vue
##########
@@ -181,10 +181,9 @@ export default {
               catchMessage: this.$t('error.fetching.async.job.result')
             })
           }
-          this.closeAction()
         }).catch(error => {
           this.$notifyError(error)
-        })
+        }).finally(() => { this.closeAction() })

Review comment:
       It's caused because of both actionLoading not being set to false and not initiating form closure post completion of the task. And merely, closing the form should do, however, I've reset the actionLoading parameter as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org