You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/05 19:54:27 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request #685: Rename concurrency to partitions in ExecutionContext
andygrove opened a new pull request #685:
URL: https://github.com/apache/arrow-datafusion/pull/685
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #684.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
See #684
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Rename `with_concurrency` to `with_partitions` and rename some associated internal attributes
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Yes! This is a breaking API change, so we should be careful to review the changes and naming to make sure we are happy with them.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #685: Rename concurrency to partitions in ExecutionContext
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #685:
URL: https://github.com/apache/arrow-datafusion/pull/685#issuecomment-874307544
Hehe :laughing:
I had a slightly different idea / proposal in https://github.com/apache/arrow-datafusion/pull/683
I think we might want to still keep a configuration for `concurrency` / number of the number of threads to use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove closed pull request #685: Rename concurrency to partitions in ExecutionContext
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #685:
URL: https://github.com/apache/arrow-datafusion/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #685: Rename concurrency to partitions in ExecutionContext
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #685:
URL: https://github.com/apache/arrow-datafusion/pull/685#issuecomment-874394111
Closed in favor of https://github.com/apache/arrow-datafusion/pull/683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #685: Rename concurrency to partitions in ExecutionContext
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #685:
URL: https://github.com/apache/arrow-datafusion/pull/685#issuecomment-874394111
Closed in favor of https://github.com/apache/arrow-datafusion/pull/683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #685: Rename concurrency to partitions in ExecutionContext
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #685:
URL: https://github.com/apache/arrow-datafusion/pull/685#issuecomment-874307544
Hehe :laughing:
I had a slightly different idea / proposal in https://github.com/apache/arrow-datafusion/pull/683
I think we might want to still keep a configuration for `concurrency` / number of the number of threads to use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove closed pull request #685: Rename concurrency to partitions in ExecutionContext
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #685:
URL: https://github.com/apache/arrow-datafusion/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org