You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@curator.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/08/15 10:48:07 UTC
[GitHub] [curator] tisonkun opened a new pull request, #476: CURATOR-685. Cleanup docs and setups for the old site deployment
tisonkun opened a new pull request, #476:
URL: https://github.com/apache/curator/pull/476
This refers to CURATOR-685.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on a diff in pull request #476: CURATOR-685. Cleanup docs and setups for the old site deployment
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #476:
URL: https://github.com/apache/curator/pull/476#discussion_r1294721185
##########
src/site/confluence/compatibility.confluence:
##########
@@ -1,10 +0,0 @@
-h1. API Compatibility
Review Comment:
Yeah. I think these reports should actually report for every PR and guard that we're in a healthy state instead of showing on the website - I highly suspect who will read these pages.
For supplychain reports, users should be able to run the command and generate on a specific commit / version, instead of relying on the SNAPSHOT reports shown before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] kezhuw commented on a diff in pull request #476: CURATOR-685. Cleanup docs and setups for the old site deployment
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on code in PR #476:
URL: https://github.com/apache/curator/pull/476#discussion_r1294663584
##########
curator-test/src/site/confluence/index.confluence:
##########
@@ -1,10 +0,0 @@
-h1. Testing Utilities
Review Comment:
This is merged with "utilities.confluence" to https://curator.apache.org/docs/utilities. That is good! It is a subset of that page.
##########
src/site/confluence/compatibility.confluence:
##########
@@ -1,10 +0,0 @@
-h1. API Compatibility
Review Comment:
These compatibility reports are left over. I think @tisonkun already has solution for javadoc. This sounds similar. It is a a good to have compatibility reports , but without ci in old site, these were dated anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #476: CURATOR-685. Cleanup docs and setups for the old site deployment
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #476:
URL: https://github.com/apache/curator/pull/476#issuecomment-1679777355
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #476: CURATOR-685. Cleanup docs and setups for the old site deployment
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #476:
URL: https://github.com/apache/curator/pull/476#issuecomment-1679090963
> except generated one
You remind me of porting the Javadoc generation to the site repo...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun merged pull request #476: CURATOR-685. Cleanup docs and setups for the old site deployment
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #476:
URL: https://github.com/apache/curator/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on a diff in pull request #476: CURATOR-685. Cleanup docs and setups for the old site deployment
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #476:
URL: https://github.com/apache/curator/pull/476#discussion_r1294721185
##########
src/site/confluence/compatibility.confluence:
##########
@@ -1,10 +0,0 @@
-h1. API Compatibility
Review Comment:
Yeah. I think these reports should actually report for every PR and guard that we're in a healthy state instead of showing on the website - I highly suspect who will read these pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org