You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2017/02/07 18:20:27 UTC
[GitHub] cordova-lib pull request #517: Cb 12017
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/517
Cb 12017
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Updates npm dependencies used in cordova-lib.
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-12017
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/517.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #517
----
commit bf5be5804497ba4d6ed45eda4aaed97134f576aa
Author: Audrey So <au...@apache.org>
Date: 2017-02-04T00:44:31Z
CB:12017 : updated dependencies
commit 0d00eecd98da5e418d54bb58bca91c1ffb8476de
Author: Audrey So <au...@apache.org>
Date: 2017-02-06T19:03:13Z
CB-12017 : updated dependencies rewire and request
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #517: CB- 12017: update npm dependencies
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/517
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/517?src=pr&el=h1) Report
> Merging [#517](https://codecov.io/gh/apache/cordova-lib/pull/517?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/a9605411ab007d700849c971043f0c211c06100c?src=pr&el=desc) will **not impact** coverage.
```diff
@@ Coverage Diff @@
## master #517 +/- ##
======================================
Coverage 81.8% 81.8%
======================================
Files 68 68
Lines 5459 5459
Branches 1072 1072
======================================
Hits 4466 4466
Misses 993 993
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/517?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/cordova/lazy_load.js](https://codecov.io/gh/apache/cordova-lib/compare/a9605411ab007d700849c971043f0c211c06100c...0d00eecd98da5e418d54bb58bca91c1ffb8476de?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvbGF6eV9sb2FkLmpz) | `77.7% <�> (�)` | :white_check_mark: |
| [...va-lib/src/cordova/metadata/blackberry10_parser.js](https://codecov.io/gh/apache/cordova-lib/compare/a9605411ab007d700849c971043f0c211c06100c...0d00eecd98da5e418d54bb58bca91c1ffb8476de?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvbWV0YWRhdGEvYmxhY2tiZXJyeTEwX3BhcnNlci5qcw==) | `65.07% <�> (�)` | :white_check_mark: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/517?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/517?src=pr&el=footer). Last update [a960541...fc5fac6](https://codecov.io/gh/apache/cordova-lib/compare/a9605411ab007d700849c971043f0c211c06100c...fc5fac63197643d0a68e3888166d17b8ee6d19b5?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #517: CB- 12017: update npm dependencies
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/517
@audreyso can you rebase this from master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #517: CB- 12017: update npm dependencies
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/517
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #517: CB- 12017: update npm dependencies
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/517
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #517: CB- 12017: update npm dependencies
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/517
@stevengill yes ...done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #517: CB- 12017: update npm dependencies
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/517
still need to update at elementtree, jshint, q, and shelljs --> when updated will cause tests to fail
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org