You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/18 14:48:33 UTC
[GitHub] [rocketmq-client-go] ShannonDing opened a new pull request #420:
fix(strategy): change the deafult mq sort to ASC when do rebalance.
ShannonDing opened a new pull request #420: fix(strategy): change the deafult mq sort to ASC when do rebalance.
URL: https://github.com/apache/rocketmq-client-go/pull/420
close #419
the message queue list got from the broker should be sort by ASC before do rebalance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] T5800 commented on issue #420: fix(strategy):
change the deafult mq sort to ASC when do rebalance.
Posted by GitBox <gi...@apache.org>.
T5800 commented on issue #420: fix(strategy): change the deafult mq sort to ASC when do rebalance.
URL: https://github.com/apache/rocketmq-client-go/pull/420#issuecomment-588058880
It is awesome, it worked for me. The brokers of CPP METAQ and GO METAQ are not conflict anymore.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] vongosling merged pull request #420:
fix(strategy): change the deafult mq sort to ASC when do rebalance.
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #420: fix(strategy): change the deafult mq sort to ASC when do rebalance.
URL: https://github.com/apache/rocketmq-client-go/pull/420
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #420:
fix(strategy): change the deafult mq sort to ASC when do rebalance.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #420: fix(strategy): change the deafult mq sort to ASC when do rebalance.
URL: https://github.com/apache/rocketmq-client-go/pull/420#issuecomment-587511099
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/420?src=pr&el=h1) Report
> Merging [#420](https://codecov.io/gh/apache/rocketmq-client-go/pull/420?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/adc707f730e136a1969d4f0ab7adffcb173ebd9f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/420?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #420 +/- ##
======================================
Coverage 24.9% 24.9%
======================================
Files 48 48
Lines 5480 5480
======================================
Hits 1365 1365
Misses 3928 3928
Partials 187 187
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/420?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [consumer/consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/420/diff?src=pr&el=tree#diff-Y29uc3VtZXIvY29uc3VtZXIuZ28=) | `16.25% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/420?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/420?src=pr&el=footer). Last update [adc707f...a957fb8](https://codecov.io/gh/apache/rocketmq-client-go/pull/420?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services