You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/05/01 19:47:48 UTC
[GitHub] [airflow] potiuk opened a new pull request, #31000: Limit Pdpyras dependency in pagerduty provider
potiuk opened a new pull request, #31000:
URL: https://github.com/apache/airflow/pull/31000
The pdpyras 5.0.0 released an hour ago has broken install_requires (not including deprecation dependency).
When the issue is fixed: https://github.com/PagerDuty/pdpyras/issues/100 we can just replace it with != 5.0.0
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #31000: Limit Pdpyras dependency in pagerduty provider
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #31000:
URL: https://github.com/apache/airflow/pull/31000#issuecomment-1530131188
5.0.1 is released with the fix so we can update the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #31000: Limit Pdpyras dependency in pagerduty provider
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #31000: Limit Pdpyras dependency in pagerduty provider
URL: https://github.com/apache/airflow/pull/31000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #31000: Limit Pdpyras dependency in pagerduty provider
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31000:
URL: https://github.com/apache/airflow/pull/31000#issuecomment-1530133977
> [5.0.1](https://github.com/PagerDuty/pdpyras/releases/tag/v5.0.1) is released with the fix so we can update the PR
Indeed. That was super-quick-fix :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #31000: Limit Pdpyras dependency in pagerduty provider
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31000:
URL: https://github.com/apache/airflow/pull/31000#issuecomment-1530134415
> 5.0.0 is yanked in pypi so anyway it won't be taken into account
So we do not need that one at all then. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #31000: Limit Pdpyras dependency in pagerduty provider
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #31000:
URL: https://github.com/apache/airflow/pull/31000#discussion_r1181843195
##########
airflow/providers/pagerduty/provider.yaml:
##########
@@ -36,7 +36,8 @@ versions:
dependencies:
- apache-airflow>=2.4.0
- - pdpyras>=4.1.2
+ # Pdpyras 5.0.0 has wrong dependencies https://github.com/PagerDuty/pdpyras/issues/100
+ - pdpyras>=4.1.2,!=5.0.0
Review Comment:
5.0.0 is yanked in pypi so anyway it won't be taken into account
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org