[GitHub] [arrow-adbc] WillAyd commented on a diff in pull request #868: feat(c/driver/postgresql): TimestampTz write

["WillAyd (via GitHub)" <gi...@apache.org>]

WillAyd commented on code in PR #868:
URL: https://github.com/apache/arrow-adbc/pull/868#discussion_r1251171948


##########
c/driver/postgresql/connection.cc:
##########
@@ -1025,6 +1025,18 @@ AdbcStatusCode PostgresConnection::SetOption(const char* key, const char* value,
     }
     return ADBC_STATUS_OK;
   }
+
+  if (std::strcmp(key, "TIME ZONE") == 0) {
+    std::string query = std::string("SET TIME ZONE '") + std::string(value) + "'";

Review Comment:
   Yea either of those are viable; I think better to start with the latter, though I'm not sure where to manage that lifecycle. Is the `BindStream` struct in statement.cc supposed to be a suitable home for managing a transaction? The type introspection happens there, but I don't know that is the best place to put BEGIN/COMMIT statements. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org