You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martijn Dashorst <ma...@gmail.com> on 2007/06/10 22:32:34 UTC
Re: svn commit: r545923 - in /incubator/wicket/trunk: jdk-1.5/wicket-examples/pom.xml pom.xml testing/wicket-threadtest/pom.xml
Can we fix the commons-logging thing too? I.E. in dependency
management force commons-logging 1.0.4, though not specify it? And
possibly excluding it from the spring dependency?
I don't like to fix the world, but this forces us to ship logkit,
avalon and other stuff I don't want to support.
Martijn
On 6/10/07, almaw@apache.org <al...@apache.org> wrote:
> Author: almaw
> Date: Sun Jun 10 12:42:30 2007
> New Revision: 545923
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=545923
> Log:
> Don't bother bringing in transitive log4j dep
>
> Modified:
> incubator/wicket/trunk/jdk-1.5/wicket-examples/pom.xml
> incubator/wicket/trunk/pom.xml
> incubator/wicket/trunk/testing/wicket-threadtest/pom.xml
>
> Modified: incubator/wicket/trunk/jdk-1.5/wicket-examples/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.5/wicket-examples/pom.xml?view=diff&rev=545923&r1=545922&r2=545923
> ==============================================================================
> --- incubator/wicket/trunk/jdk-1.5/wicket-examples/pom.xml (original)
> +++ incubator/wicket/trunk/jdk-1.5/wicket-examples/pom.xml Sun Jun 10 12:42:30 2007
> @@ -95,10 +95,6 @@
> <groupId>org.slf4j</groupId>
> <artifactId>slf4j-log4j12</artifactId>
> </dependency>
> - <dependency>
> - <groupId>log4j</groupId>
> - <artifactId>log4j</artifactId>
> - </dependency>
> </dependencies>
> <build>
> <plugins>
>
> Modified: incubator/wicket/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/pom.xml?view=diff&rev=545923&r1=545922&r2=545923
> ==============================================================================
> --- incubator/wicket/trunk/pom.xml (original)
> +++ incubator/wicket/trunk/pom.xml Sun Jun 10 12:42:30 2007
> @@ -387,11 +387,6 @@
> <artifactId>slf4j-log4j12</artifactId>
> <scope>test</scope>
> </dependency>
> - <dependency>
> - <groupId>log4j</groupId>
> - <artifactId>log4j</artifactId>
> - <scope>test</scope>
> - </dependency>
> </dependencies>
> <build>
> <extensions>
>
> Modified: incubator/wicket/trunk/testing/wicket-threadtest/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/testing/wicket-threadtest/pom.xml?view=diff&rev=545923&r1=545922&r2=545923
> ==============================================================================
> --- incubator/wicket/trunk/testing/wicket-threadtest/pom.xml (original)
> +++ incubator/wicket/trunk/testing/wicket-threadtest/pom.xml Sun Jun 10 12:42:30 2007
> @@ -78,5 +78,10 @@
> <groupId>commons-httpclient</groupId>
> <artifactId>commons-httpclient</artifactId>
> </dependency>
> +
> + <dependency>
> + <groupId>org.slf4j</groupId>
> + <artifactId>slf4j-log4j12</artifactId>
> + </dependency>
> </dependencies>
> </project>
>
>
>
--
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.6 contains a very important fix. Download Wicket now!
http://wicketframework.org
Re: svn commit: r545923 - in /incubator/wicket/trunk: jdk-1.5/wicket-examples/pom.xml
pom.xml testing/wicket-threadtest/pom.xml
Posted by Al Maw <wi...@almaw.com>.
Ceki Gulcu wrote:
> You might want to consider jcl104-over-slf4j as a JCL replacement. The
> jcl104-over-slf4j modules is compatible with the JCL API but uses
> SLF4J underneath.
Wow, we get a visit from the man himself. Hi Ceki. ;-)
We don't want to force this dependency on the users. If they want to
replace commons-logging with jcl104-over-slf4j stuff, they're quite free
to, but we really shouldn't be pushing that at people (even if it is
"better").
I'm going to write a wiki page detailing the options. We should probably
put it near the getting started stuff, as otherwise people will wonder
why they have no logging. :-)
Regards,
Al
--
Alastair Maw
Wicket-biased blog at http://herebebeasties.com
Re: svn commit: r545923 - in /incubator/wicket/trunk: jdk-1.5/wicket-examples/pom.xml pom.xml testing/wicket-threadtest/pom.xml
Posted by Ceki Gulcu <ce...@qos.ch>.
Martijn Dashorst <ma...@...> writes:
>
> Can we fix the commons-logging thing too? I.E. in dependency
> management force commons-logging 1.0.4, though not specify it? And
> possibly excluding it from the spring dependency?
>
> I don't like to fix the world, but this forces us to ship logkit,
> avalon and other stuff I don't want to support.
>
Hello Martijn,
You might want to consider jcl104-over-slf4j as a JCL replacement. The
jcl104-over-slf4j modules is compatible with the JCL API but uses
SLF4J underneath.
See http://www.slf4j.org/manual.html#gradual for more details.
If you are interested, please let me know, I'll be glad to help.
Cheers,
Re: svn commit: r545923 - in /incubator/wicket/trunk: jdk-1.5/wicket-examples/pom.xml pom.xml testing/wicket-threadtest/pom.xml
Posted by Martijn Dashorst <ma...@gmail.com>.
On 6/10/07, Al Maw <wi...@almaw.com> wrote:
> Sure. We can't exclude commons-logging, as it's a genuine dependency for
> their code, so to do so would be wrong. But we can fix their
> non-optional compile-scoped dependencies on servlet-api, log4j, logkit
> and avalon.
There is still one problem in our examples: we statically bind to
commons-logging (the spring examples still use it). That should be
fixed too, perhaps not now, but in the near future.
> I've done so in the dependenciesManagement section, which hopefully
> should work. Let me know if it doesn't.
It should work in my opinion (haven't tried).
Thanks!
Martijn
--
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.6 contains a very important fix. Download Wicket now!
http://wicketframework.org
Re: svn commit: r545923 - in /incubator/wicket/trunk: jdk-1.5/wicket-examples/pom.xml
pom.xml testing/wicket-threadtest/pom.xml
Posted by Al Maw <wi...@almaw.com>.
Martijn Dashorst wrote:
> Can we fix the commons-logging thing too? I.E. in dependency
> management force commons-logging 1.0.4, though not specify it? And
> possibly excluding it from the spring dependency?
>
> I don't like to fix the world, but this forces us to ship logkit,
> avalon and other stuff I don't want to support.
Sure. We can't exclude commons-logging, as it's a genuine dependency for
their code, so to do so would be wrong. But we can fix their
non-optional compile-scoped dependencies on servlet-api, log4j, logkit
and avalon.
I've done so in the dependenciesManagement section, which hopefully
should work. Let me know if it doesn't.
Regards,
Al