[GitHub] [doris] github-actions[bot] commented on a diff in pull request #19134: [profile](rf) refactor profile of runtime filters

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #19134:
URL: https://github.com/apache/doris/pull/19134#discussion_r1178575835


##########
be/src/exprs/runtime_filter.h:
##########
@@ -394,16 +396,15 @@ class IRuntimeFilter {
     // parent profile
     // only effect on consumer
     std::unique_ptr<RuntimeProfile> _profile;
-    // unix millis
-    RuntimeProfile::Counter* _await_time_cost = nullptr;
 
     /// Time in ms (from MonotonicMillis()), that the filter was registered.
     const int64_t registration_time_;
 
     const bool _enable_pipeline_exec;
 
     bool _profile_init = false;
-
+    doris::Mutex _profile_mutex;
+    std::string _name = "";

Review Comment:
   warning: redundant string initialization [readability-redundant-string-init]
   
   ```suggestion
       std::string _name;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org