[GitHub] [kafka] mjsax commented on a change in pull request #10856: MINOR: Small optimizations and removal of unused code in Streams

[GitBox <gi...@apache.org>]

mjsax commented on a change in pull request #10856:
URL: https://github.com/apache/kafka/pull/10856#discussion_r648739553



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##########
@@ -294,14 +293,6 @@ public final void removeAllThreadLevelSensors(final String threadId) {
         return tagMap;
     }
 
-    public Map<String, String> bufferLevelTagMap(final String threadId,

Review comment:
       \cc @cadonna Any though on this? (Similar below)

##########
File path: streams/src/main/java/org/apache/kafka/streams/StoreQueryParameters.java
##########
@@ -25,8 +25,8 @@
  */
 public class StoreQueryParameters<T> {
 
-    private Integer partition;
-    private boolean staleStores;
+    private final Integer partition;
+    private final boolean staleStores;

Review comment:
       Wondering who this is possible? Should the build not fail for this case? \cc @vvcephei 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org