You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/12 02:14:15 UTC

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #9994: fix issue#9976

jingshanglu commented on a change in pull request #9994:
URL: https://github.com/apache/shardingsphere/pull/9994#discussion_r611288987



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/BindingTableRule.java
##########
@@ -80,7 +80,12 @@ public String getBindingActualTable(final String dataSource, final String logicT
         throw new ShardingSphereConfigurationException("Cannot find binding actual table, data source: %s, logic table: %s, other actual table: %s", dataSource, logicTable, otherActualTable);
     }
     
-    Collection<String> getAllLogicTables() {
+    /**
+     * Get list of logical table.
+     *
+     * @return logical tables.
+     */

Review comment:
       @tristaZero 
   
   There are three citations.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org