You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by nick dimiduk <nd...@gmail.com> on 2015/04/10 06:40:13 UTC
Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-9993
https://issues.apache.org/jira/browse/AMBARI-9993
Repository: ambari
Description
-------
Per JIRA
Diffs
-----
ambari-server/src/main/resources/common-services/PHOENIX/4.4.0.2.3/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/PHOENIX/4.4.0.2.3/package/scripts/__init__.py PRE-CREATION
ambari-server/src/main/resources/common-services/PHOENIX/4.4.0.2.3/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/PHOENIX/4.4.0.2.3/package/scripts/phoenix_query_server.py PRE-CREATION
ambari-server/src/main/resources/common-services/PHOENIX/4.4.0.2.3/package/scripts/phoenix_service.py PRE-CREATION
ambari-server/src/main/resources/common-services/PHOENIX/4.4.0.2.3/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/PHOENIX/metainfo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/33064/diff/
Testing
-------
Thanks,
nick dimiduk
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by nick dimiduk <nd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/
-----------------------------------------------------------
(Updated April 15, 2015, 11:07 a.m.)
Review request for Ambari.
Changes
-------
patch v04 from JIRA.
Bugs: AMBARI-9993
https://issues.apache.org/jira/browse/AMBARI-9993
Repository: ambari
Description
-------
Per JIRA
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-log4j.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-policy.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-site.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metrics.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/draining_servers.rb PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/hbaseSmokeVerify.sh PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/__init__.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/functions.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_client.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_decommission.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_master.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_regionserver.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_service.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_upgrade.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_windows.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_queryserver.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_service.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/upgrade.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase-smoke.sh.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_client_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_grant_permissions.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_master_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_regionserver_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/regionservers.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/widgets.json PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_master.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_regionserver.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_service_check.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_phoenix_queryserver.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json PRE-CREATION
ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json PRE-CREATION
ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json PRE-CREATION
Diff: https://reviews.apache.org/r/33064/diff/
Testing
-------
Thanks,
nick dimiduk
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by nick dimiduk <nd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/
-----------------------------------------------------------
(Updated April 14, 2015, 2:21 p.m.)
Review request for Ambari.
Changes
-------
Patch v03 from JIRA.
Bugs: AMBARI-9993
https://issues.apache.org/jira/browse/AMBARI-9993
Repository: ambari
Description
-------
Per JIRA
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-log4j.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-policy.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-site.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metrics.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/draining_servers.rb PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/hbaseSmokeVerify.sh PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/__init__.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/functions.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_client.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_decommission.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_master.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_regionserver.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_service.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_upgrade.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_windows.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_queryserver.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_service.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/upgrade.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase-smoke.sh.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_client_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_grant_permissions.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_master_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_regionserver_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/regionservers.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/widgets.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 0cf8ff2
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_master.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_regionserver.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_service_check.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_phoenix_queryserver.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json PRE-CREATION
Diff: https://reviews.apache.org/r/33064/diff/
Testing
-------
Thanks,
nick dimiduk
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by nick dimiduk <nd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/
-----------------------------------------------------------
(Updated April 13, 2015, 4:08 p.m.)
Review request for Ambari.
Changes
-------
patch v2 from JIRA.
Bugs: AMBARI-9993
https://issues.apache.org/jira/browse/AMBARI-9993
Repository: ambari
Description
-------
Per JIRA
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-log4j.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-policy.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-site.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metrics.json PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/draining_servers.rb PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/hbaseSmokeVerify.sh PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/__init__.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/functions.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_client.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_decommission.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_master.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_regionserver.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_service.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_upgrade.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_windows.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_queryserver.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_service.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/upgrade.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase-smoke.sh.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_client_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_grant_permissions.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_master_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_regionserver_jaas.conf.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/regionservers.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/widgets.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 0cf8ff2
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_master.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_regionserver.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_service_check.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/HBASE/test_phoenix_queryserver.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json PRE-CREATION
Diff: https://reviews.apache.org/r/33064/diff/
Testing
-------
Thanks,
nick dimiduk
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by nick dimiduk <nd...@gmail.com>.
> On April 10, 2015, 4:46 p.m., Alejandro Fernandez wrote:
> > We should add unit tests for the new component.
Examples?
- nick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/#review79779
-----------------------------------------------------------
On April 10, 2015, 1:58 p.m., nick dimiduk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33064/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 1:58 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-9993
> https://issues.apache.org/jira/browse/AMBARI-9993
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Per JIRA
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml 1032024
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33064/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> nick dimiduk
>
>
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/#review79779
-----------------------------------------------------------
We should add unit tests for the new component.
- Alejandro Fernandez
On April 10, 2015, 8:58 p.m., nick dimiduk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33064/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 8:58 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-9993
> https://issues.apache.org/jira/browse/AMBARI-9993
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Per JIRA
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml 1032024
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33064/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> nick dimiduk
>
>
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 10, 2015, 11:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py, line 27
> > <https://reviews.apache.org/r/33064/diff/2/?file=923824#file923824line27>
> >
> > In a kerberized cluster, will first need to kinit before starting or stopping. Is that going to go in this patch or a future one?
>
> nick dimiduk wrote:
> I've not tested this. Should probably come in this patch. I see no example of this in `hbase_service.py`, is there some other example I can follow?
I'm ok with incremental patches, so the next patch addresses security.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/#review79777
-----------------------------------------------------------
On April 14, 2015, 9:21 p.m., nick dimiduk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33064/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 9:21 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-9993
> https://issues.apache.org/jira/browse/AMBARI-9993
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Per JIRA
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-policy.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/configuration/hbase-site.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/metrics.json PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/draining_servers.rb PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/files/hbaseSmokeVerify.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/__init__.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/functions.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_client.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_decommission.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_regionserver.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_service.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/hbase_upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_windows.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_queryserver.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/phoenix_service.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/upgrade.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase-smoke.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_client_jaas.conf.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_grant_permissions.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_master_jaas.conf.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/hbase_regionserver_jaas.conf.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/templates/regionservers.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/widgets.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 0cf8ff2
> ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_client.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_master.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_regionserver.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/HBASE/test_hbase_service_check.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/HBASE/test_phoenix_queryserver.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33064/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> nick dimiduk
>
>
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by nick dimiduk <nd...@gmail.com>.
> On April 10, 2015, 4:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml, line 120
> > <https://reviews.apache.org/r/33064/diff/2/?file=923821#file923821line120>
> >
> > This means we'll need to add Phoenix to the Rolling Upgrade orchestration. Take a look at upgrade-2.2.xml to find out where it goes.
I'm not sure what you're thinking here. Before 2.3 there is no query server, so there's nothing to upgrade/bounce. In 2.3, query server is an optional component, so nothing for force install that wasn't there.
What does "versionAdvertised" mean? I never found a schema or descriptions for these fields, so I just copied what other HBase components did. Should we just remove this tag?
> On April 10, 2015, 4:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py, line 21
> > <https://reviews.apache.org/r/33064/diff/2/?file=923823#file923823line21>
> >
> > We should use named imports. This makes it easier to find which module things come from.
Import * is used throughout the code base.
> On April 10, 2015, 4:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py, line 21
> > <https://reviews.apache.org/r/33064/diff/2/?file=923824#file923824line21>
> >
> > Use named imports.
likewise.
> On April 10, 2015, 4:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py, line 27
> > <https://reviews.apache.org/r/33064/diff/2/?file=923824#file923824line27>
> >
> > In a kerberized cluster, will first need to kinit before starting or stopping. Is that going to go in this patch or a future one?
I've not tested this. Should probably come in this patch. I see no example of this in `hbase_service.py`, is there some other example I can follow?
> On April 10, 2015, 4:36 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py, line 40
> > <https://reviews.apache.org/r/33064/diff/2/?file=923824#file923824line40>
> >
> > Should probably check that the exists first.
Why? The -f will silently ignore the lack of file -- it's only there in case the above kill command is run. Normal execution phx_daemon_script will take care of it.
- nick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/#review79777
-----------------------------------------------------------
On April 10, 2015, 1:58 p.m., nick dimiduk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33064/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 1:58 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-9993
> https://issues.apache.org/jira/browse/AMBARI-9993
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Per JIRA
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml 1032024
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33064/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> nick dimiduk
>
>
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/#review79777
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml
<https://reviews.apache.org/r/33064/#comment129340>
This means we'll need to add Phoenix to the Rolling Upgrade orchestration. Take a look at upgrade-2.2.xml to find out where it goes.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
<https://reviews.apache.org/r/33064/#comment129339>
We should use named imports. This makes it easier to find which module things come from.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
<https://reviews.apache.org/r/33064/#comment129342>
Use named imports.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
<https://reviews.apache.org/r/33064/#comment129343>
In a kerberized cluster, will first need to kinit before starting or stopping. Is that going to go in this patch or a future one?
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
<https://reviews.apache.org/r/33064/#comment129344>
Should probably check that the exists first.
- Alejandro Fernandez
On April 10, 2015, 8:58 p.m., nick dimiduk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33064/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 8:58 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-9993
> https://issues.apache.org/jira/browse/AMBARI-9993
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Per JIRA
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml 1032024
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33064/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> nick dimiduk
>
>
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by nick dimiduk <nd...@gmail.com>.
> On April 10, 2015, 4:22 p.m., Yusaku Sako wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml, line 115
> > <https://reviews.apache.org/r/33064/diff/2/?file=923821#file923821line115>
> >
> > If we define this here, this will become available for HDP 2.0, 2.1, and 2.2 (we don't want to do that, correct)?
Yeah, you're right. I need to create a new HBASE/1.1.0.2.3/metainfo.xml ? Does it mostly inherit, or will I copy all this stuff over there? What other pieces will I need to point at this new service version?
> On April 10, 2015, 4:22 p.m., Yusaku Sako wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml, line 23
> > <https://reviews.apache.org/r/33064/diff/2/?file=923821#file923821line23>
> >
> > IMO this should be called this "HBase" as Phoenix is an optional feature that can be enabled on HBase. Maybe we might want to mention Phoenix in the description.
>From what I can see, Phoenix is always installed along with HBase (the rpm/dpg anyway). What's optional is deploying the query server.
There was a conversation on internal SME HBase list that suggested this is a good way to go, raise visibility of Phoenix.
- nick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/#review79768
-----------------------------------------------------------
On April 10, 2015, 1:58 p.m., nick dimiduk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33064/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 1:58 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-9993
> https://issues.apache.org/jira/browse/AMBARI-9993
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Per JIRA
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml 1032024
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33064/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> nick dimiduk
>
>
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/#review79768
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml
<https://reviews.apache.org/r/33064/#comment129313>
IMO this should be called this "HBase" as Phoenix is an optional feature that can be enabled on HBase. Maybe we might want to mention Phoenix in the description.
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml
<https://reviews.apache.org/r/33064/#comment129323>
If we define this here, this will become available for HDP 2.0, 2.1, and 2.2 (we don't want to do that, correct)?
- Yusaku Sako
On April 10, 2015, 8:58 p.m., nick dimiduk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33064/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 8:58 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-9993
> https://issues.apache.org/jira/browse/AMBARI-9993
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Per JIRA
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml 1032024
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 98f0473
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33064/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> nick dimiduk
>
>
Re: Review Request 33064: AMBARI-9993 Add support for management of
Phoenix Query Server to HDP Stack
Posted by nick dimiduk <nd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/
-----------------------------------------------------------
(Updated April 10, 2015, 1:58 p.m.)
Review request for Ambari.
Changes
-------
patch v01 from JIRA.
Bugs: AMBARI-9993
https://issues.apache.org/jira/browse/AMBARI-9993
Repository: ambari
Description
-------
Per JIRA
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml 1032024
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 98f0473
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py PRE-CREATION
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py PRE-CREATION
Diff: https://reviews.apache.org/r/33064/diff/
Testing
-------
Thanks,
nick dimiduk