You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/18 05:38:24 UTC

[GitHub] [shardingsphere] menghaoranss opened a new pull request #5664: Remove '\n' when judging schema

menghaoranss opened a new pull request #5664:
URL: https://github.com/apache/shardingsphere/pull/5664


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #5664: Remove '\n' when judging schema

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5664:
URL: https://github.com/apache/shardingsphere/pull/5664#issuecomment-629964308


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5664?src=pr&el=h1) Report
   > Merging [#5664](https://codecov.io/gh/apache/shardingsphere/pull/5664?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/9584f8cafda5f542cb898103de7ec397b909f4cf&el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5664/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5664?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5664   +/-   ##
   =========================================
     Coverage     56.11%   56.11%           
     Complexity      434      434           
   =========================================
     Files          1143     1143           
     Lines         20290    20290           
     Branches       3679     3678    -1     
   =========================================
   + Hits          11385    11386    +1     
     Misses         8226     8226           
   + Partials        679      678    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5664?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/5664/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtY29uZmlnY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvY29uZmlnY2VudGVyL0NvbmZpZ0NlbnRlci5qYXZh) | `84.70% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...e/configcenter/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/5664/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtY29uZmlnY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvY29uZmlnY2VudGVyL2xpc3RlbmVyL1NjaGVtYUNoYW5nZWRMaXN0ZW5lci5qYXZh) | `76.78% <100.00%> (+1.78%)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5664?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5664?src=pr&el=footer). Last update [9584f8c...f1380a5](https://codecov.io/gh/apache/shardingsphere/pull/5664?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #5664: Remove '\n' when judging schema

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5664:
URL: https://github.com/apache/shardingsphere/pull/5664


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org