You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2018/06/21 17:53:20 UTC
[GitHub] activemq-artemis pull request #2156: ARTEMIS-1951 allow queue's user to be u...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2156
ARTEMIS-1951 allow queue's user to be updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1951
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2156
----
commit 01cbeabf1eb91b50bc3e675421a5091ab87712e5
Author: Justin Bertram <jb...@...>
Date: 2018-06-21T17:50:11Z
ARTEMIS-1951 allow queue's user to be updated
----
---
[GitHub] activemq-artemis issue #2156: ARTEMIS-1951 allow queue's user to be updated
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2156
@jbertram theres an issue this introduced change will cause see inline comment please
---
[GitHub] activemq-artemis pull request #2156: ARTEMIS-1951 allow queue's user to be u...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2156#discussion_r197624300
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java ---
@@ -511,6 +512,10 @@ public QueueBinding updateQueue(SimpleString name,
changed = true;
queue.setExclusive(exclusive);
}
+ if ((user != null && !user.equals(queue.getUser()) || (user == null && queue.getUser() != null))) {
+ changed = true;
+ queue.setUser(SimpleString.toSimpleString(user));
--- End diff --
Slight issue here in the logic that the older methods if invoked to update a queue will clear the user associated with the queue , as they will pass in null causing user to be set to null no matter.
---
[GitHub] activemq-artemis pull request #2156: ARTEMIS-1951 allow queue's user to be u...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2156#discussion_r197792644
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java ---
@@ -511,6 +512,10 @@ public QueueBinding updateQueue(SimpleString name,
changed = true;
queue.setExclusive(exclusive);
}
+ if ((user != null && !user.equals(queue.getUser()) || (user == null && queue.getUser() != null))) {
+ changed = true;
+ queue.setUser(SimpleString.toSimpleString(user));
--- End diff --
@jbertram ive sent a PR to address this https://github.com/apache/activemq-artemis/pull/2161
---
[GitHub] activemq-artemis pull request #2156: ARTEMIS-1951 allow queue's user to be u...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2156
---