[GitHub] [hive] pvargacl commented on a change in pull request #1795: HIVE-24550: Cleanup only transaction information for the current DriverContext

[GitBox <gi...@apache.org>]

pvargacl commented on a change in pull request #1795:
URL: https://github.com/apache/hive/pull/1795#discussion_r551277198



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java
##########
@@ -527,11 +527,15 @@ void release() {
     release(!hiveLocks.isEmpty());
   }
 
-  void destroy() {
+  void destroy(String queryIdFromDriver) {
+    // We need cleanup transactions, even if we did not acquired locks yet
+    // However TxnManager is bound to session, so wee need to check if it is already handling a new query

Review comment:
       If txnManager is handling a new query, the previous one must be either committed or aborted otherwise the second query's openTxn call would have failed with an exception.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org