You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/01 07:18:14 UTC

[GitHub] [arrow] projjal opened a new pull request #11819: [C++][Gandiva] Fix split_part function in gandiva

projjal opened a new pull request #11819:
URL: https://github.com/apache/arrow/pull/11819


   Split_part function sporadically returns error. This happens when the output string is empty. The call to gdv_fn_context_arena_malloc with size 0 returns nullptr when there has been no earlier call which leads to the error.
   The allocation here is also redundant since we can return slice of the input string


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #11819: [C++][Gandiva] Fix split_part function in gandiva

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11819:
URL: https://github.com/apache/arrow/pull/11819#issuecomment-983358684


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #11819: ARROW-14936: [C++][Gandiva] Fix split_part function in gandiva

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11819:
URL: https://github.com/apache/arrow/pull/11819#issuecomment-983359108






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #11819: ARROW-14936: [C++][Gandiva] Fix split_part function in gandiva

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11819:
URL: https://github.com/apache/arrow/pull/11819#issuecomment-985450626


   Benchmark runs are scheduled for baseline = d94fea78d68b9a43c42ee330a26bec4d09f059c1 and contender = bdb064bd31f6a5eeec688ac6bad88d81e8be8ca5. bdb064bd31f6a5eeec688ac6bad88d81e8be8ca5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/835448fd35624452afca129e9875e714...a139c43c5bd74a67a01b7e9a4d1e5481/)
   [Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/00aac2c39a534236b62e2b966e282e3d...b23e7c48ae8f4b5c88545352c6da6cb8/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/97c802958b634ea1928de037e5bc7ad7...44170bd7c7464b36a45a2228461b372d/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #11819: ARROW-14936: [C++][Gandiva] Fix split_part function in gandiva

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11819:
URL: https://github.com/apache/arrow/pull/11819#issuecomment-985450626


   Benchmark runs are scheduled for baseline = d94fea78d68b9a43c42ee330a26bec4d09f059c1 and contender = bdb064bd31f6a5eeec688ac6bad88d81e8be8ca5. bdb064bd31f6a5eeec688ac6bad88d81e8be8ca5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/835448fd35624452afca129e9875e714...a139c43c5bd74a67a01b7e9a4d1e5481/)
   [Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/00aac2c39a534236b62e2b966e282e3d...b23e7c48ae8f4b5c88545352c6da6cb8/)
   [Finished :arrow_down:0.27% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/97c802958b634ea1928de037e5bc7ad7...44170bd7c7464b36a45a2228461b372d/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #11819: ARROW-14936: [C++][Gandiva] Fix split_part function in gandiva

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11819:
URL: https://github.com/apache/arrow/pull/11819#issuecomment-985450626


   Benchmark runs are scheduled for baseline = d94fea78d68b9a43c42ee330a26bec4d09f059c1 and contender = bdb064bd31f6a5eeec688ac6bad88d81e8be8ca5. bdb064bd31f6a5eeec688ac6bad88d81e8be8ca5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/835448fd35624452afca129e9875e714...a139c43c5bd74a67a01b7e9a4d1e5481/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/00aac2c39a534236b62e2b966e282e3d...b23e7c48ae8f4b5c88545352c6da6cb8/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/97c802958b634ea1928de037e5bc7ad7...44170bd7c7464b36a45a2228461b372d/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #11819: ARROW-14936: [C++][Gandiva] Fix split_part function in gandiva

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11819:
URL: https://github.com/apache/arrow/pull/11819#issuecomment-985450626


   Benchmark runs are scheduled for baseline = d94fea78d68b9a43c42ee330a26bec4d09f059c1 and contender = bdb064bd31f6a5eeec688ac6bad88d81e8be8ca5. bdb064bd31f6a5eeec688ac6bad88d81e8be8ca5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/835448fd35624452afca129e9875e714...a139c43c5bd74a67a01b7e9a4d1e5481/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/00aac2c39a534236b62e2b966e282e3d...b23e7c48ae8f4b5c88545352c6da6cb8/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/97c802958b634ea1928de037e5bc7ad7...44170bd7c7464b36a45a2228461b372d/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pravindra closed pull request #11819: ARROW-14936: [C++][Gandiva] Fix split_part function in gandiva

Posted by GitBox <gi...@apache.org>.
pravindra closed pull request #11819:
URL: https://github.com/apache/arrow/pull/11819


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org