[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #232: HTTPCLIENT-2095: Use slf4j interpolation instead of string concatenation where possible

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #232:
URL: https://github.com/apache/httpcomponents-client/pull/232#discussion_r448876371



##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/LenientHttpResponseParser.java
##########
@@ -85,7 +85,7 @@ protected ClassicHttpResponse createMessage(final CharArrayBuffer buffer) throws
             return super.createMessage(buffer);
         } catch (final HttpException ex) {
             if (this.log.isDebugEnabled()) {
-                this.log.debug("Garbage in response: " + buffer.toString());
+                this.log.debug("Garbage in response: {}", buffer.toString());

Review comment:
       @carterkozak Generally the overhead of string concatenation should not matter that much given all log entries are guarded with `#is<LogLevel>Enabled` but I am fine with using more native `slf4j` notation.
   
   @michael-o Shall I merge the PR or is there still something that needs work?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org