You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/14 01:00:13 UTC

[GitHub] [spark] turboFei edited a comment on issue #24533: [SPARK-27637][Shuffle] For nettyBlockTransferService, if IOException occurred while fetching data, check whether relative executor is alive before retry

turboFei edited a comment on issue #24533: [SPARK-27637][Shuffle] For nettyBlockTransferService, if IOException occurred while fetching data, check whether relative executor is alive  before retry
URL: https://github.com/apache/spark/pull/24533#issuecomment-492038984
 
 
   I have added a unit test, I create a driverEndpointRef which always return false when ask any message.
   And let mock client throw IOException when sendRpc, then the nettyBlockTransferService will get if relative executors is alive, which must be false.
   At last, I let the blockFetchListener throw ExecutorDeadException when it fetch failed for ExecutorDeadException. @cloud-fan 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org