You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Paul Rogers (Code Review)" <ge...@cloudera.org> on 2019/01/26 02:05:37 UTC
[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations
Paul Rogers has uploaded a new patch set (#2) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11228 )
Change subject: IMPALA-7450. Set thread name during refresh/load operations
......................................................................
IMPALA-7450. Set thread name during refresh/load operations
This adds a small utility class for annotating the current thread's name
during potentially long-running operations such as refresh/load. With
this change, jstack output now includes useful thread names like:
During startup:
"main [invalidating metadata - 128/428 dbs complete]"
While loading a fresh table:
"pool-4-thread-12 [Loading metadata for: foo_db.foo_table] [Loading
metadata for all partition(s) of foo_db.foo_table]"
Pool refreshing metadata for a particular path:
"pool-23-thread-5 [Refreshing file metadata for path:
hdfs://nameservice1/path/to/partdir..."
This patch is tricky to automate tests for, but I verified it manually
by jstacking a catalogd while performing some workload. Also added a
simple unit test to verify the thread renaming behavior.
Change-Id: Ic7c850d6bb2eedc375ee567c19eb17add335f60c
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/TableLoader.java
A fe/src/main/java/org/apache/impala/util/ThreadNameAnnotator.java
A fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java
5 files changed, 245 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/11228/2
--
To view, visit http://gerrit.cloudera.org:8080/11228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7c850d6bb2eedc375ee567c19eb17add335f60c
Gerrit-Change-Number: 11228
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>