You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Saisai Shao (JIRA)" <ji...@apache.org> on 2017/07/11 17:00:03 UTC
[jira] [Comment Edited] (SPARK-14151) Propose to refactor and
expose Metrics Sink and Source interface
[ https://issues.apache.org/jira/browse/SPARK-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082508#comment-16082508 ]
Saisai Shao edited comment on SPARK-14151 at 7/11/17 5:00 PM:
--------------------------------------------------------------
Thanks [~jiangxb] for your response. I'm not sure if it requires a standard SPIP for this JIRA, because this is a simple improvement and we just only expose APIs, not create new APIs. I would think only big new changes require SPIP, there's not so many things I could address in the SPIP. Would like to hear other's comment.
{quote}
The purpose of an SPIP is to inform and involve the user community in major improvements to the Spark codebase throughout the development process, to increase the likelihood that user needs are met.
SPIPs should be used for significant user-facing or cross-cutting changes, not small incremental improvements. When in doubt, if a committer thinks a change needs an SPIP, it does.
{quote}
was (Author: jerryshao):
Thanks [~jiangxb] for your response. I'm not sure if it requires a standard SPIP for this JIRA, because this is a simple improvement and we just only expose APIs, not create new APIs. I would think only big new changes require SPIP, there's not so many things I could address in the SPIP. Would like to hear other's comment.
> Propose to refactor and expose Metrics Sink and Source interface
> ----------------------------------------------------------------
>
> Key: SPARK-14151
> URL: https://issues.apache.org/jira/browse/SPARK-14151
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Reporter: Saisai Shao
> Priority: Minor
>
> MetricsSystem is designed for plug-in different sources and sinks, user could write their own sources and sinks and configured through metrics.properties, MetricsSystem will register it through reflection. But current Source and Sink interface is private, which means user cannot create their own sources and sinks unless using the same package.
> So here propose to expose source and sink interface, this will let user build and maintain their own source and sink, alleviate the maintenance overhead of spark codebase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org