You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/28 23:09:12 UTC
[GitHub] [superset] justinpark opened a new pull request, #20909: fix(plugin-chart-pivot-table): Invalid Formats Date Fields
justinpark opened a new pull request, #20909:
URL: https://github.com/apache/superset/pull/20909
### SUMMARY
When a custom date field value converted in a string format, some aggregators truncated to the first four digits.
This is caused by the parseFloat function which converts to first matched number rather than NaN(Not-A-Number) value.
This commit replaces the parseFloat by Number wrapper to handle this case correctly.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="571" alt="Screen_Shot_2022-07-28_at_3_28_39_PM" src="https://user-images.githubusercontent.com/1392866/181651783-323cf0ed-1cd8-4492-9096-b49e0f259065.png">
After:
<img width="620" alt="Screen_Shot_2022-07-28_at_3_32_41_PM" src="https://user-images.githubusercontent.com/1392866/181651918-5ae5db95-945f-4216-90bd-5cc50cb8eb5b.png">
### TESTING INSTRUCTIONS
storybook
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20909: fix(plugin-chart-pivot-table): Invalid Formats Date Fields
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20909:
URL: https://github.com/apache/superset/pull/20909#issuecomment-1198730376
# [Codecov](https://codecov.io/gh/apache/superset/pull/20909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20909](https://codecov.io/gh/apache/superset/pull/20909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c48afc0) into [master](https://codecov.io/gh/apache/superset/commit/d50784dd808cf908567e2c7f9fa67188202c59b9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d50784d) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #20909 +/- ##
=======================================
Coverage 66.21% 66.21%
=======================================
Files 1758 1758
Lines 67009 67009
Branches 7107 7107
=======================================
Hits 44369 44369
Misses 20818 20818
Partials 1822 1822
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.00% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...hart-pivot-table/src/react-pivottable/utilities.js](https://codecov.io/gh/apache/superset/pull/20909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3JlYWN0LXBpdm90dGFibGUvdXRpbGl0aWVzLmpz) | `0.00% <0.00%> (ø)` | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #20909: fix(plugin-chart-pivot-table): Invalid Formats Date Fields
Posted by GitBox <gi...@apache.org>.
john-bodley merged PR #20909:
URL: https://github.com/apache/superset/pull/20909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org