DO NOT REPLY [Bug 28922] New: - org.apache.pluto.core.impl.PortletURLImpl.setParameter

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28922>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28922

org.apache.pluto.core.impl.PortletURLImpl.setParameter

           Summary: org.apache.pluto.core.impl.PortletURLImpl.setParameter
           Product: Pluto
           Version: Current CVS
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Other
         Component: portlet container
        AssignedTo: pluto-dev@jakarta.apache.org
        ReportedBy: blumm@apache.org


This bug was reported by christof.dallermassl@hyperwave.com on pluto-dev mailing
list.

org.apache.pluto.core.impl.PortletURLImpl:

    public void setParameter(String name, String value)
    {
        if (name == null || value == null) {
            throw new IllegalArgumentException("name and value must not be 
null");
        }
        parameters.put( name, value);
    }

but the "parameters" map should have a String[] as a value, but here a String 
is set.

As theses parameters are passed to the  
org.apache.pluto.services.information.PortletURLProvider#setParameters 
method, at least the javadoc of this method is not  correct, as it states 
that the values are String[]s. I think, in the setParameter method of 
org.apache.pluto.core.impl.PortletURLImp a

parameters.put( name, new String[] {value}); 
instead of
parameters.put(name,value);

should do, what has to be done, although previously set values would be 
destroyed then. as the method's name is setParameter this is ok for me (and 
the setParameter(String, String[]) method exists.