You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Erik Bergenholtz <eb...@hortonworks.com> on 2015/05/29 21:35:56 UTC

Review Request 34826: Capacity Scheduler: Cluster association requires Ambari URL to be filled

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34826/
-----------------------------------------------------------

Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.


Repository: ambari


Description
-------

If instance of view is associated to cluster Property Validator still tries to validate empty URL, and falls into saving properties error.


Diffs
-----

  contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/PropertyValidator.java c7c7da9 

Diff: https://reviews.apache.org/r/34826/diff/


Testing
-------

Applied patch to trunk build and deployed resulting view on cluster; instantiated view without problems.


Thanks,

Erik Bergenholtz


Re: Review Request 34826: Capacity Scheduler: Cluster association requires Ambari URL to be filled

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34826/#review85781
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Nettleton


On May 29, 2015, 7:35 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34826/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 7:35 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If instance of view is associated to cluster Property Validator still tries to validate empty URL, and falls into saving properties error.
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/PropertyValidator.java c7c7da9 
> 
> Diff: https://reviews.apache.org/r/34826/diff/
> 
> 
> Testing
> -------
> 
> Applied patch to trunk build and deployed resulting view on cluster; instantiated view without problems.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>


Re: Review Request 34826: Capacity Scheduler: Cluster association requires Ambari URL to be filled

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34826/#review85783
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On May 29, 2015, 7:35 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34826/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 7:35 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If instance of view is associated to cluster Property Validator still tries to validate empty URL, and falls into saving properties error.
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/PropertyValidator.java c7c7da9 
> 
> Diff: https://reviews.apache.org/r/34826/diff/
> 
> 
> Testing
> -------
> 
> Applied patch to trunk build and deployed resulting view on cluster; instantiated view without problems.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>


Re: Review Request 34826: Capacity Scheduler: Cluster association requires Ambari URL to be filled

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34826/#review85804
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Levas


On May 29, 2015, 3:35 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34826/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 3:35 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If instance of view is associated to cluster Property Validator still tries to validate empty URL, and falls into saving properties error.
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/PropertyValidator.java c7c7da9 
> 
> Diff: https://reviews.apache.org/r/34826/diff/
> 
> 
> Testing
> -------
> 
> Applied patch to trunk build and deployed resulting view on cluster; instantiated view without problems.
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>