[jira] [Commented] (EAGLE-549) Add required field for application configuration

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/EAGLE-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500498#comment-15500498 ] 

ASF GitHub Bot commented on EAGLE-549:
--------------------------------------

GitHub user haoch opened a pull request:

    https://github.com/apache/incubator-eagle/pull/440

    EAGLE-549 Add required field for application configuration

    Support `required`:`boolean` in configuration property.
    
    ~~~
    <configuration>
            <property>
                <name>service.host</name>
                <value>localhost</value>
                <displayName>Eagle Service Host</displayName>
                <description>Eagle Service Host, default: localhost</description>
               <required>true</required>
            </property>
        </configuration>
    ~~~

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/haoch/incubator-eagle EAGLE-549

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #440
    
----
commit d0dbead01bdf4261a69186a25b87b5707c8b3367
Author: Hao Chen <ha...@apache.org>
Date:   2016-09-18T07:43:24Z

    Support to define propery as required to force providing

----


> Add required field for application configuration
> ------------------------------------------------
>
>                 Key: EAGLE-549
>                 URL: https://issues.apache.org/jira/browse/EAGLE-549
>             Project: Eagle
>          Issue Type: New Feature
>    Affects Versions: v0.5.0
>            Reporter: Hao Chen
>            Assignee: Hao Chen
>             Fix For: v0.5.0
>
>
> {code}
> <configuration>
>         <property>
>             <name>service.host</name>
>             <value>localhost</value>
>             <displayName>Eagle Service Host</displayName>
>             <description>Eagle Service Host, default: localhost</description>
>            <required>true</required>
>         </property>
>         <property>
>             <name>service.port</name>
>             <value>8080</value>
>             <displayName>Eagle Service Port</displayName>
>             <description>Eagle Service Port, default: 8080</description>
>            <required>false</required>
>         </property>
>     </configuration>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)