You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2019/03/06 07:46:43 UTC

[cordova-plugin-inappbrowser] 01/01: Reset lefttoright if not set

This is an automated email from the ASF dual-hosted git repository.

purplecabbage pushed a commit to branch purplecabbage-patch-1
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git

commit 63160de40db002cc81e2a5390e8448123a3132dc
Author: Jesse MacFadyen <pu...@gmail.com>
AuthorDate: Tue Mar 5 23:46:38 2019 -0800

    Reset lefttoright if not set
    
    This fixes #441
---
 src/android/InAppBrowser.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index 048b02a..a958186 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -682,9 +682,8 @@ public class InAppBrowser extends CordovaPlugin {
                 closeButtonColor = closeButtonColorSet;
             }
             String leftToRightSet = features.get(LEFT_TO_RIGHT);
-            if (leftToRightSet != null) {
-                leftToRight = leftToRightSet.equals("yes") ? true : false;
-            }
+            leftToRight = leftToRightSet != null && leftToRightSet.equals("yes");
+
             String toolbarColorSet = features.get(TOOLBAR_COLOR);
             if (toolbarColorSet != null) {
                 toolbarColor = android.graphics.Color.parseColor(toolbarColorSet);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org