You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/08 07:50:39 UTC
[GitHub] [incubator-kyuubi] ulysses-you opened a new pull request #1192: Refine zorder utils toByte
ulysses-you opened a new pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix some issue:
* int/long type miss update highest byte of byte array
* short/int/long same value may have different byte array
* the mask value of long is error. (1L << 31 instead of 1 << 31)
* the default value of string should be Long.Max since we pad it to 8 bytes so we can keep the ordering of null value (null last)
* boolean to byte doesn't need 4 bytes, 1 byte is enough
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#issuecomment-938437273
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1192](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b13d265) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d44ccc364470c29f522d7349042dd86a4d84b15d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d44ccc3) will **decrease** coverage by `0.06%`.
> The diff coverage is `97.43%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1192 +/- ##
============================================
- Coverage 79.06% 79.00% -0.07%
Complexity 93 93
============================================
Files 182 182
Lines 6684 6729 +45
Branches 786 796 +10
============================================
+ Hits 5285 5316 +31
- Misses 945 959 +14
Partials 454 454
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQnl0ZXNVdGlscy5zY2FsYQ==) | `92.70% <97.43%> (+3.13%)` | :arrow_up: |
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `40.71% <0.00%> (-5.19%)` | :arrow_down: |
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.52% <0.00%> (+0.11%)` | :arrow_up: |
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `55.81% <0.00%> (+2.32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ac3e6c3...b13d265](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#issuecomment-938437273
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1192](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2271b42) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d44ccc364470c29f522d7349042dd86a4d84b15d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d44ccc3) will **decrease** coverage by `0.32%`.
> The diff coverage is `97.14%`.
> :exclamation: Current head 2271b42 differs from pull request most recent head 7a0cba2. Consider uploading reports for the commit 7a0cba2 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1192 +/- ##
============================================
- Coverage 79.06% 78.74% -0.33%
Complexity 93 93
============================================
Files 182 182
Lines 6684 6752 +68
Branches 786 803 +17
============================================
+ Hits 5285 5317 +32
- Misses 945 979 +34
- Partials 454 456 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQnl0ZXNVdGlscy5zY2FsYQ==) | `92.48% <97.14%> (+2.91%)` | :arrow_up: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `76.84% <0.00%> (-14.07%)` | :arrow_down: |
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `40.71% <0.00%> (-5.19%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.33% <0.00%> (ø)` | |
| [...ala/org/apache/kyuubi/events/JsonEventLogger.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvSnNvbkV2ZW50TG9nZ2VyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.52% <0.00%> (+0.11%)` | :arrow_up: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `79.22% <0.00%> (+0.27%)` | :arrow_up: |
| [...org/apache/kyuubi/server/EventLoggingService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvRXZlbnRMb2dnaW5nU2VydmljZS5zY2FsYQ==) | `90.47% <0.00%> (+0.47%)` | :arrow_up: |
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `55.81% <0.00%> (+2.32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ac3e6c3...7a0cba2](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#discussion_r728600611
##########
File path: dev/kyuubi-extension-spark-3-1/src/test/scala/org/apache/spark/sql/ZorderCoreBenchmark.scala
##########
@@ -27,13 +27,11 @@ import org.apache.kyuubi.sql.zorder.ZorderBytesUtils
*
* To run this benchmark, temporarily change `ignore` to `test`, then run
Review comment:
the comment here is outdated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#issuecomment-938437273
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1192](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2271b42) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d44ccc364470c29f522d7349042dd86a4d84b15d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d44ccc3) will **decrease** coverage by `0.32%`.
> The diff coverage is `97.14%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1192 +/- ##
============================================
- Coverage 79.06% 78.74% -0.33%
Complexity 93 93
============================================
Files 182 182
Lines 6684 6752 +68
Branches 786 803 +17
============================================
+ Hits 5285 5317 +32
- Misses 945 979 +34
- Partials 454 456 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQnl0ZXNVdGlscy5zY2FsYQ==) | `92.48% <97.14%> (+2.91%)` | :arrow_up: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `76.84% <0.00%> (-14.07%)` | :arrow_down: |
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `40.71% <0.00%> (-5.19%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.33% <0.00%> (ø)` | |
| [...ala/org/apache/kyuubi/events/JsonEventLogger.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvSnNvbkV2ZW50TG9nZ2VyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.52% <0.00%> (+0.11%)` | :arrow_up: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `79.22% <0.00%> (+0.27%)` | :arrow_up: |
| [...org/apache/kyuubi/server/EventLoggingService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvRXZlbnRMb2dnaW5nU2VydmljZS5zY2FsYQ==) | `90.47% <0.00%> (+0.47%)` | :arrow_up: |
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `55.81% <0.00%> (+2.32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ac3e6c3...2271b42](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#issuecomment-938441304
cc @cfmcgrady @yaooqinn @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a change in pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on a change in pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#discussion_r725419394
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
##########
@@ -96,42 +101,67 @@ object ZorderBytesUtils {
def booleanToByte(a: Boolean): Array[Byte] = {
if (a) {
- intToByte(1)
+ byteToByte(1)
} else {
- intToByte(0)
+ byteToByte(0)
}
}
def byteToByte(a: Int): Array[Byte] = {
Review comment:
```scala
def byteToByte(a: Byte): Array[Byte] = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#discussion_r724782406
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
##########
@@ -96,42 +101,67 @@ object ZorderBytesUtils {
def booleanToByte(a: Boolean): Array[Byte] = {
if (a) {
- intToByte(1)
+ byteToByte(1)
Review comment:
this is for: issue 5
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
##########
@@ -96,42 +101,67 @@ object ZorderBytesUtils {
def booleanToByte(a: Boolean): Array[Byte] = {
if (a) {
- intToByte(1)
+ byteToByte(1)
} else {
- intToByte(0)
+ byteToByte(0)
}
}
def byteToByte(a: Int): Array[Byte] = {
- val tmp = (a ^ (1 << 7)).toByte
+ val tmp = (a ^ BYTE_8_MASK).toByte
Array(tmp)
}
def shortToByte(a: Short): Array[Byte] = {
- val tmp = a ^ (1 << 15)
+ val tmp = a ^ BYTE_16_MASK
Array(((tmp >> 8) & 0xff).toByte, (tmp & 0xff).toByte)
}
def intToByte(a: Int): Array[Byte] = {
- val tmp = a ^ (1 << 31)
val result = new Array[Byte](4)
var i = 0
- while (i < 3) {
- val offset = i * 8
- result(3 - i) = ((tmp >> offset) & 0xff).toByte
- i += 1
+ if (a <= Short.MaxValue) {
+ val tmp = a ^ BYTE_16_MASK
+ while (i <= 1) {
+ val offset = i * 8
+ result(3 - i) = ((tmp >> offset) & 0xff).toByte
+ i += 1
+ }
+ } else {
+ val tmp = a ^ BYTE_32_MASK
+ while (i <= 3) {
+ val offset = i * 8
+ result(3 - i) = ((tmp >> offset) & 0xff).toByte
+ i += 1
+ }
}
result
}
def longToByte(a: Long): Array[Byte] = {
- val tmp = a ^ (1 << 63)
val result = new Array[Byte](8)
var i = 0
- while (i < 7) {
- val offset = i * 8
- result(7 - i) = ((tmp >> offset) & 0xff).toByte
- i += 1
+ if (a <= Short.MaxValue) {
Review comment:
this is for: issue 2
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
##########
@@ -96,42 +101,67 @@ object ZorderBytesUtils {
def booleanToByte(a: Boolean): Array[Byte] = {
if (a) {
- intToByte(1)
+ byteToByte(1)
} else {
- intToByte(0)
+ byteToByte(0)
}
}
def byteToByte(a: Int): Array[Byte] = {
- val tmp = (a ^ (1 << 7)).toByte
+ val tmp = (a ^ BYTE_8_MASK).toByte
Array(tmp)
}
def shortToByte(a: Short): Array[Byte] = {
- val tmp = a ^ (1 << 15)
+ val tmp = a ^ BYTE_16_MASK
Array(((tmp >> 8) & 0xff).toByte, (tmp & 0xff).toByte)
}
def intToByte(a: Int): Array[Byte] = {
- val tmp = a ^ (1 << 31)
val result = new Array[Byte](4)
var i = 0
- while (i < 3) {
- val offset = i * 8
- result(3 - i) = ((tmp >> offset) & 0xff).toByte
- i += 1
+ if (a <= Short.MaxValue) {
+ val tmp = a ^ BYTE_16_MASK
+ while (i <= 1) {
+ val offset = i * 8
+ result(3 - i) = ((tmp >> offset) & 0xff).toByte
+ i += 1
+ }
+ } else {
+ val tmp = a ^ BYTE_32_MASK
+ while (i <= 3) {
Review comment:
this is for: issue 1
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
##########
@@ -96,42 +101,67 @@ object ZorderBytesUtils {
def booleanToByte(a: Boolean): Array[Byte] = {
if (a) {
- intToByte(1)
+ byteToByte(1)
} else {
- intToByte(0)
+ byteToByte(0)
}
}
def byteToByte(a: Int): Array[Byte] = {
- val tmp = (a ^ (1 << 7)).toByte
+ val tmp = (a ^ BYTE_8_MASK).toByte
Array(tmp)
}
def shortToByte(a: Short): Array[Byte] = {
- val tmp = a ^ (1 << 15)
+ val tmp = a ^ BYTE_16_MASK
Array(((tmp >> 8) & 0xff).toByte, (tmp & 0xff).toByte)
}
def intToByte(a: Int): Array[Byte] = {
- val tmp = a ^ (1 << 31)
val result = new Array[Byte](4)
var i = 0
- while (i < 3) {
- val offset = i * 8
- result(3 - i) = ((tmp >> offset) & 0xff).toByte
- i += 1
+ if (a <= Short.MaxValue) {
Review comment:
this is for: issue 2
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
##########
@@ -96,42 +101,67 @@ object ZorderBytesUtils {
def booleanToByte(a: Boolean): Array[Byte] = {
if (a) {
- intToByte(1)
+ byteToByte(1)
} else {
- intToByte(0)
+ byteToByte(0)
}
}
def byteToByte(a: Int): Array[Byte] = {
- val tmp = (a ^ (1 << 7)).toByte
+ val tmp = (a ^ BYTE_8_MASK).toByte
Array(tmp)
}
def shortToByte(a: Short): Array[Byte] = {
- val tmp = a ^ (1 << 15)
+ val tmp = a ^ BYTE_16_MASK
Array(((tmp >> 8) & 0xff).toByte, (tmp & 0xff).toByte)
}
def intToByte(a: Int): Array[Byte] = {
- val tmp = a ^ (1 << 31)
val result = new Array[Byte](4)
var i = 0
- while (i < 3) {
- val offset = i * 8
- result(3 - i) = ((tmp >> offset) & 0xff).toByte
- i += 1
+ if (a <= Short.MaxValue) {
+ val tmp = a ^ BYTE_16_MASK
+ while (i <= 1) {
+ val offset = i * 8
+ result(3 - i) = ((tmp >> offset) & 0xff).toByte
+ i += 1
+ }
+ } else {
+ val tmp = a ^ BYTE_32_MASK
+ while (i <= 3) {
+ val offset = i * 8
+ result(3 - i) = ((tmp >> offset) & 0xff).toByte
+ i += 1
+ }
}
result
}
def longToByte(a: Long): Array[Byte] = {
- val tmp = a ^ (1 << 63)
val result = new Array[Byte](8)
var i = 0
- while (i < 7) {
- val offset = i * 8
- result(7 - i) = ((tmp >> offset) & 0xff).toByte
- i += 1
+ if (a <= Short.MaxValue) {
+ val tmp = a ^ BYTE_16_MASK
+ while (i <= 1) {
+ val offset = i * 8
+ result(7 - i) = ((tmp >> offset) & 0xff).toByte
+ i += 1
+ }
+ } else if (a <= Int.MaxValue) {
+ val tmp = a ^ BYTE_32_MASK
+ while (i <= 3) {
+ val offset = i * 8
+ result(7 - i) = ((tmp >> offset) & 0xff).toByte
+ i += 1
+ }
+ } else {
+ val tmp = a ^ BYTE_64_MASK
+ while (i <= 7) {
Review comment:
this is for: issue 1
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
##########
@@ -25,6 +25,11 @@ import org.apache.spark.unsafe.types.UTF8String
import org.apache.kyuubi.sql.KyuubiSQLExtensionException
object ZorderBytesUtils {
+ private val BYTE_8_MASK = 1 << 7
+ private val BYTE_16_MASK = 1 << 15
+ private val BYTE_32_MASK = 1 << 31
+ private val BYTE_64_MASK = 1L << 63
Review comment:
this is for: issue 3
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
##########
@@ -188,10 +218,10 @@ object ZorderBytesUtils {
case DoubleType =>
Double.MaxValue
case StringType =>
- UTF8String.fromBytes(new Array[Byte](0))
+ // we pad string to 8 bytes so it's equal to long
+ UTF8String.fromBytes(longToByte(Long.MaxValue))
Review comment:
this is for: issue 4
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
##########
@@ -96,42 +101,67 @@ object ZorderBytesUtils {
def booleanToByte(a: Boolean): Array[Byte] = {
if (a) {
- intToByte(1)
+ byteToByte(1)
} else {
- intToByte(0)
+ byteToByte(0)
}
}
def byteToByte(a: Int): Array[Byte] = {
- val tmp = (a ^ (1 << 7)).toByte
+ val tmp = (a ^ BYTE_8_MASK).toByte
Array(tmp)
}
def shortToByte(a: Short): Array[Byte] = {
- val tmp = a ^ (1 << 15)
+ val tmp = a ^ BYTE_16_MASK
Array(((tmp >> 8) & 0xff).toByte, (tmp & 0xff).toByte)
}
def intToByte(a: Int): Array[Byte] = {
- val tmp = a ^ (1 << 31)
val result = new Array[Byte](4)
var i = 0
- while (i < 3) {
- val offset = i * 8
- result(3 - i) = ((tmp >> offset) & 0xff).toByte
- i += 1
+ if (a <= Short.MaxValue) {
+ val tmp = a ^ BYTE_16_MASK
+ while (i <= 1) {
+ val offset = i * 8
+ result(3 - i) = ((tmp >> offset) & 0xff).toByte
+ i += 1
+ }
+ } else {
+ val tmp = a ^ BYTE_32_MASK
+ while (i <= 3) {
+ val offset = i * 8
+ result(3 - i) = ((tmp >> offset) & 0xff).toByte
+ i += 1
+ }
}
result
}
def longToByte(a: Long): Array[Byte] = {
- val tmp = a ^ (1 << 63)
val result = new Array[Byte](8)
var i = 0
- while (i < 7) {
- val offset = i * 8
- result(7 - i) = ((tmp >> offset) & 0xff).toByte
- i += 1
+ if (a <= Short.MaxValue) {
+ val tmp = a ^ BYTE_16_MASK
+ while (i <= 1) {
+ val offset = i * 8
+ result(7 - i) = ((tmp >> offset) & 0xff).toByte
+ i += 1
+ }
+ } else if (a <= Int.MaxValue) {
Review comment:
this is for: issue 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#discussion_r725419771
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
##########
@@ -96,42 +101,67 @@ object ZorderBytesUtils {
def booleanToByte(a: Boolean): Array[Byte] = {
if (a) {
- intToByte(1)
+ byteToByte(1)
} else {
- intToByte(0)
+ byteToByte(0)
}
}
def byteToByte(a: Int): Array[Byte] = {
Review comment:
good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#issuecomment-938437273
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1192](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b13d265) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d44ccc364470c29f522d7349042dd86a4d84b15d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d44ccc3) will **decrease** coverage by `0.06%`.
> The diff coverage is `97.43%`.
> :exclamation: Current head b13d265 differs from pull request most recent head 2271b42. Consider uploading reports for the commit 2271b42 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1192 +/- ##
============================================
- Coverage 79.06% 79.00% -0.07%
Complexity 93 93
============================================
Files 182 182
Lines 6684 6729 +45
Branches 786 796 +10
============================================
+ Hits 5285 5316 +31
- Misses 945 959 +14
Partials 454 454
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQnl0ZXNVdGlscy5zY2FsYQ==) | `92.70% <97.43%> (+3.13%)` | :arrow_up: |
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `40.71% <0.00%> (-5.19%)` | :arrow_down: |
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.52% <0.00%> (+0.11%)` | :arrow_up: |
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `55.81% <0.00%> (+2.32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ac3e6c3...2271b42](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#issuecomment-938437273
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1192](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a0cba2) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d44ccc364470c29f522d7349042dd86a4d84b15d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d44ccc3) will **decrease** coverage by `0.32%`.
> The diff coverage is `97.14%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1192 +/- ##
============================================
- Coverage 79.06% 78.74% -0.33%
Complexity 93 93
============================================
Files 182 182
Lines 6684 6752 +68
Branches 786 803 +17
============================================
+ Hits 5285 5317 +32
- Misses 945 979 +34
- Partials 454 456 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQnl0ZXNVdGlscy5zY2FsYQ==) | `92.48% <97.14%> (+2.91%)` | :arrow_up: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `76.84% <0.00%> (-14.07%)` | :arrow_down: |
| [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `40.71% <0.00%> (-5.19%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.33% <0.00%> (ø)` | |
| [...ala/org/apache/kyuubi/events/JsonEventLogger.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvSnNvbkV2ZW50TG9nZ2VyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.52% <0.00%> (+0.11%)` | :arrow_up: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `79.22% <0.00%> (+0.27%)` | :arrow_up: |
| [...org/apache/kyuubi/server/EventLoggingService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvRXZlbnRMb2dnaW5nU2VydmljZS5zY2FsYQ==) | `90.47% <0.00%> (+0.47%)` | :arrow_up: |
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `55.81% <0.00%> (+2.32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ac3e6c3...7a0cba2](https://codecov.io/gh/apache/incubator-kyuubi/pull/1192?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#issuecomment-939237757
thanks for review, merging to master !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1192: Refine zorder utils toByte
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1192:
URL: https://github.com/apache/incubator-kyuubi/pull/1192#discussion_r728610083
##########
File path: dev/kyuubi-extension-spark-3-1/src/test/scala/org/apache/spark/sql/ZorderCoreBenchmark.scala
##########
@@ -27,13 +27,11 @@ import org.apache.kyuubi.sql.zorder.ZorderBytesUtils
*
* To run this benchmark, temporarily change `ignore` to `test`, then run
Review comment:
update it in https://github.com/apache/incubator-kyuubi/pull/1226 since it's trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org