You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/02/22 18:00:27 UTC
[jira] Commented: (HBASE-2245) Unnecessary call to syncWal(region);
in HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836723#action_12836723 ]
stack commented on HBASE-2245:
------------------------------
Patch looks great Benoît.
Does this work?
{code}
42 + writeToWAL &= puts[i].getWriteToWAL();
{code}
The &= of a boolean?
> Unnecessary call to syncWal(region); in HRegionServer
> -----------------------------------------------------
>
> Key: HBASE-2245
> URL: https://issues.apache.org/jira/browse/HBASE-2245
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.20.3
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
> Fix For: 0.20.4, 0.21.0
>
> Attachments: 0001-HBASE-2245-Don-t-call-syncWal-when-not-needed.patch
>
>
> Some methods unconditionally call {{syncWal}} on the region even though the operation specifically asks to not use the WAL.
> The most obvious example is in {{incrementColumnValue}} where, regardless of the value of the argument {{writeToWAL}}, we always call {{syncWal(region);}}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.