You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/01 19:49:03 UTC
[GitHub] [beam] ahmedabu98 opened a new pull request, #24471: [BigQueryIO] Use final destination table schema and metadata when creating temp tables
ahmedabu98 opened a new pull request, #24471:
URL: https://github.com/apache/beam/pull/24471
Fixes #22372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24471: [BigQueryIO] Use final destination table schema and metadata when creating temp tables
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24471:
URL: https://github.com/apache/beam/pull/24471#issuecomment-1335648411
java precommit test failure irrelevant flake: `org.apache.beam.runners.dataflow.worker.StreamingDataflowWorkerTest.testLatencyAttributionToQueuedState[0: [streamingEngine=false]]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #24471: [BigQueryIO] Use final destination table schema and metadata when creating temp tables
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #24471:
URL: https://github.com/apache/beam/pull/24471#issuecomment-1335557442
I believe it's an unnecessary check, since those are the only two existing CreateDispositions: https://github.com/apache/beam/blob/46919b7bbf7d9c68a182c78edc84e97cd7d6b95a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java#L2170
that condition will always be true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24471: [BigQueryIO] Use final destination table schema and metadata when creating temp tables
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24471:
URL: https://github.com/apache/beam/pull/24471#issuecomment-1334426920
The test failure looks relevant: https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Commit/988/testReport/junit/org.apache.beam.sdk.io.gcp.bigquery/BigQuerySchemaUpdateOptionsIT/runWriteTestTempTables/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #24471: [BigQueryIO] Use final destination table schema and metadata when creating temp tables
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #24471:
URL: https://github.com/apache/beam/pull/24471#issuecomment-1334901522
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24471: [BigQueryIO] Use final destination table schema and metadata when creating temp tables
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24471:
URL: https://github.com/apache/beam/pull/24471#issuecomment-1335271356
Thanks for the quick fix. Just wondering why we do not need the condition of `if (createDisposition.equals(CreateDisposition.CREATE_IF_NEEDED)
|| createDisposition.equals(CreateDisposition.CREATE_NEVER))` that is removed in https://github.com/apache/beam/pull/17365/files#diff-3edb3abd8909e7075e679e8b93420d4119858d6a9418b6ec10a204a592f062abL682-L692 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #24471: [BigQueryIO] Use final destination table schema and metadata when creating temp tables
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #24471:
URL: https://github.com/apache/beam/pull/24471#issuecomment-1334837173
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24471: [BigQueryIO] Use final destination table schema and metadata when creating temp tables
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24471:
URL: https://github.com/apache/beam/pull/24471#issuecomment-1334312956
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #24471: [BigQueryIO] Use final destination table schema and metadata when creating temp tables
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #24471:
URL: https://github.com/apache/beam/pull/24471#issuecomment-1334309698
R: @MarcoRob
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #24471: [BigQueryIO] Use final destination table schema and metadata when creating temp tables
Posted by GitBox <gi...@apache.org>.
Abacn merged PR #24471:
URL: https://github.com/apache/beam/pull/24471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org