You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/25 19:19:59 UTC
Review Request: Fixed Statistics.archive test flakiness by adding a call to
Clock::settle.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10120/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See above. I also cleaned up the test by using newer style asserts.
This addresses bug MESOS-411.
https://issues.apache.org/jira/browse/MESOS-411
Diffs
-----
third_party/libprocess/src/tests/statistics_tests.cpp fc63471da1e81cf61fb7e319b99aaa2782877d5b
Diff: https://reviews.apache.org/r/10120/diff/
Testing
-------
./tests --gtest_filter="Statistics.*" --gtest_repeat=10000 --gtest_break_on_failure
Thanks,
Ben Mahler
Re: Review Request: Fixed Statistics.archive test flakiness by adding a call
to Clock::settle.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10120/#review18367
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 25, 2013, 6:19 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10120/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 6:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above. I also cleaned up the test by using newer style asserts.
>
>
> This addresses bug MESOS-411.
> https://issues.apache.org/jira/browse/MESOS-411
>
>
> Diffs
> -----
>
> third_party/libprocess/src/tests/statistics_tests.cpp fc63471da1e81cf61fb7e319b99aaa2782877d5b
>
> Diff: https://reviews.apache.org/r/10120/diff/
>
>
> Testing
> -------
>
> ./tests --gtest_filter="Statistics.*" --gtest_repeat=10000 --gtest_break_on_failure
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed Statistics.archive test flakiness by adding a call
to Clock::settle.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10120/#review18359
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 25, 2013, 6:19 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10120/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 6:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above. I also cleaned up the test by using newer style asserts.
>
>
> This addresses bug MESOS-411.
> https://issues.apache.org/jira/browse/MESOS-411
>
>
> Diffs
> -----
>
> third_party/libprocess/src/tests/statistics_tests.cpp fc63471da1e81cf61fb7e319b99aaa2782877d5b
>
> Diff: https://reviews.apache.org/r/10120/diff/
>
>
> Testing
> -------
>
> ./tests --gtest_filter="Statistics.*" --gtest_repeat=10000 --gtest_break_on_failure
>
>
> Thanks,
>
> Ben Mahler
>
>