You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/07 09:15:24 UTC

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #1046: webclient: minimum HTTP 1.1 support

yamt opened a new pull request #1046:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1046


   ## Summary
   Add minimum HTTP 1.1 support.
   
   My motivation is to be able to communicate with a server which rejects HTTP 1.0.
   
   ## Impact
   
   ## Testing
   A version ported to linux has been tested against:
   
       * http://httpbin.org/stream/10
       
       * Docker API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1046: webclient: minimum HTTP 1.1 support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1046:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1046


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #1046: webclient: minimum HTTP 1.1 support

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #1046:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1046#discussion_r820629336



##########
File path: netutils/webclient/webclient.c
##########
@@ -174,7 +179,8 @@ struct conn_s
 
 /* flags for wget_s::internal_flags */
 
-#define	WGET_FLAG_GOT_CONTENT_LENGTH	1
+#define	WGET_FLAG_GOT_CONTENT_LENGTH	1U
+#define	WGET_FLAG_CHUNKED				2U

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1046: webclient: minimum HTTP 1.1 support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1046:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1046#discussion_r820621436



##########
File path: netutils/webclient/webclient.c
##########
@@ -174,7 +179,8 @@ struct conn_s
 
 /* flags for wget_s::internal_flags */
 
-#define	WGET_FLAG_GOT_CONTENT_LENGTH	1
+#define	WGET_FLAG_GOT_CONTENT_LENGTH	1U
+#define	WGET_FLAG_CHUNKED				2U

Review comment:
       let's align




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org