You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/17 22:31:42 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25022:
[SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.unsafe.types
package
dongjoon-hyun commented on a change in pull request #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.unsafe.types package
URL: https://github.com/apache/spark/pull/25022#discussion_r304669199
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -45,7 +45,8 @@ import org.apache.spark.sql.catalyst.util._
import org.apache.spark.sql.catalyst.util.DateTimeUtils.instantToMicros
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
-import org.apache.spark.unsafe.types._
+
Review comment:
```
[error] /home/jenkins/workspace/SparkPullRequestBuilder@2/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala:49:0: There should be no empty line separating imports in the same group.
[error] Total time: 19 s, completed Jul 17, 2019 3:29:10 PM
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org