You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2012/11/23 22:42:58 UTC
[jira] [Created] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
stack created HBASE-7214:
----------------------------
Summary: CleanerChore logs too much, so much so it obscures all else that is going on
Key: HBASE-7214
URL: https://issues.apache.org/jira/browse/HBASE-7214
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.3
Reporter: stack
Testing 0.94.3RC0, I see loads of this in logs:
{code}
2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
1
{code}
There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503313#comment-13503313 ]
Jesse Yates commented on HBASE-7214:
------------------------------------
But its important to know those files aren't being deleted! Seriously though, putting that on 'trace' would be find IMO. I'll work on a patch (hopefully this weekend).
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504039#comment-13504039 ]
stack commented on HBASE-7214:
------------------------------
You going to commit then Jesse? Mr Committer?
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
> Fix For: 0.96.0, 0.94.4
>
> Attachments: hbase-7214-v0.patch
>
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505112#comment-13505112 ]
Hudson commented on HBASE-7214:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #276 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/276/])
HBASE-7214: CleanerChore logs too much, so much so it obscures all else that is going on (Revision 1414229)
Result = FAILURE
jyates :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/TimeToLiveHFileCleaner.java
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
> Fix For: 0.96.0, 0.94.4
>
> Attachments: hbase-7214-v0.patch
>
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504037#comment-13504037 ]
stack commented on HBASE-7214:
------------------------------
+1 on commit. On commit, I'd wrap the log messages in and if (TRACE) to avoid our making objects we won't use.
I find the logging annoying. Would be +1 on committing to 0.94 for 0.94.4 (not enough to sink an RC IMO).
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
> Fix For: 0.96.0, 0.94.4
>
> Attachments: hbase-7214-v0.patch
>
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates resolved HBASE-7214.
--------------------------------
Resolution: Fixed
Committed to trunk and 0.94.4
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
> Fix For: 0.96.0, 0.94.4
>
> Attachments: hbase-7214-v0.patch
>
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-7214:
-------------------------------
Attachment: hbase-7214-v0.patch
Dropped the most prominent logs to trace, so if you really need the info, you can get at it (helpful for debugging), but shouldn't come up in most cases.
No notable perf impact by continuing to log, as this all runs in a background thread.
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
> Attachments: hbase-7214-v0.patch
>
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl reassigned HBASE-7214:
------------------------------------
Assignee: Jesse Yates
Can you have a look Jesse?
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7214:
---------------------------------
Fix Version/s: 0.94.4
0.96.0
+1 on patch.
[~saint.ack@gmail.com] How annoying do feel these are. Are they hiding other useful messages in the noise?
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
> Fix For: 0.96.0, 0.94.4
>
> Attachments: hbase-7214-v0.patch
>
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504042#comment-13504042 ]
Jesse Yates commented on HBASE-7214:
------------------------------------
[~saint.ack@gmail.com] I'll get on it... this afternoon
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
> Fix For: 0.96.0, 0.94.4
>
> Attachments: hbase-7214-v0.patch
>
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504757#comment-13504757 ]
Hudson commented on HBASE-7214:
-------------------------------
Integrated in HBase-TRUNK #3568 (See [https://builds.apache.org/job/HBase-TRUNK/3568/])
HBASE-7214: CleanerChore logs too much, so much so it obscures all else that is going on (Revision 1414229)
Result = FAILURE
jyates :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/TimeToLiveHFileCleaner.java
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
> Fix For: 0.96.0, 0.94.4
>
> Attachments: hbase-7214-v0.patch
>
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7214) CleanerChore logs too much, so much
so it obscures all else that is going on
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504787#comment-13504787 ]
Hudson commented on HBASE-7214:
-------------------------------
Integrated in HBase-0.94 #602 (See [https://builds.apache.org/job/HBase-0.94/602/])
HBASE-7214: CleanerChore logs too much, so much so it obscures all else that is going on (Revision 1414244)
Result = SUCCESS
jyates :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/cleaner/TimeToLiveHFileCleaner.java
> CleanerChore logs too much, so much so it obscures all else that is going on
> ----------------------------------------------------------------------------
>
> Key: HBASE-7214
> URL: https://issues.apache.org/jira/browse/HBASE-7214
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: stack
> Assignee: Jesse Yates
> Fix For: 0.96.0, 0.94.4
>
> Attachments: hbase-7214-v0.patch
>
>
> Testing 0.94.3RC0, I see loads of this in logs:
> {code}
> 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706219757 is not deletable according t#
> 14 2012-11-23 13:39:40,488 DEBUG org.apache.hadoop.hbase.master.cleaner.CleanerChore: file:/tmp/hbase-stack/hbase/.oldlogs/192.168.1.73%2C61033%2C1353705880078.1353706221210 is not deletable according t#
> 1
> {code}
> There is too much of it. Can we cut back some?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira