You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/07/25 10:04:36 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1079: refactor: unify dirs
acelyc111 opened a new pull request, #1079:
URL: https://github.com/apache/incubator-pegasus/pull/1079
https://github.com/apache/incubator-pegasus/issues/1053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje commented on pull request #1079: refactor: Move some common files out of rdsn directory
Posted by GitBox <gi...@apache.org>.
neverchanje commented on PR #1079:
URL: https://github.com/apache/incubator-pegasus/pull/1079#issuecomment-1195008221
```
[ RUN ] meta_bulk_load_http_test.start_compaction_test
got signal id: 11
Segmentation fault (core dumped)
```
Seems bulkload has some bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1079: refactor: Move some common files out of rdsn directory
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1079:
URL: https://github.com/apache/incubator-pegasus/pull/1079#discussion_r929598710
##########
src/rdsn/src/runtime/security/security.thrift:
##########
@@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.
-include "../../dsn.thrift"
+include "../../../../../idl/dsn.thrift"
Review Comment:
Of course, we will refactor the code and only leave one unique base.thrift in Pegasus later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje commented on a diff in pull request #1079: refactor: Move some common files out of rdsn directory
Posted by GitBox <gi...@apache.org>.
neverchanje commented on code in PR #1079:
URL: https://github.com/apache/incubator-pegasus/pull/1079#discussion_r929527599
##########
src/rdsn/src/runtime/security/security.thrift:
##########
@@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.
-include "../../dsn.thrift"
+include "../../../../../idl/dsn.thrift"
Review Comment:
dsn.thrift in rdsn/src/ looks fine to me, why did you move it to an outer directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1079: refactor: Move some common files out of rdsn directory
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1079:
URL: https://github.com/apache/incubator-pegasus/pull/1079#issuecomment-1195089136
> start_compaction_test
not related to this pr, we tracked it by issue, https://github.com/apache/incubator-pegasus/issues/1060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1079: refactor: Move some common files out of rdsn directory
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1079:
URL: https://github.com/apache/incubator-pegasus/pull/1079#discussion_r929596565
##########
src/rdsn/src/runtime/security/security.thrift:
##########
@@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.
-include "../../dsn.thrift"
+include "../../../../../idl/dsn.thrift"
Review Comment:
dsn.thrift contains some common thrift structures which will be used for not only rdsn, but also client libs. Its name 'dsn.thrift' is not accurate, maybe 'base.thrift' would be better, like it named in client lib directories(e.g. https://github.com/apache/incubator-pegasus/blob/master/java-client/idl/base.thrift).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1079: refactor: Move some common files out of rdsn directory
Posted by GitBox <gi...@apache.org>.
acelyc111 merged PR #1079:
URL: https://github.com/apache/incubator-pegasus/pull/1079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 closed pull request #1079: refactor: Move some common files out of rdsn directory
Posted by GitBox <gi...@apache.org>.
acelyc111 closed pull request #1079: refactor: Move some common files out of rdsn directory
URL: https://github.com/apache/incubator-pegasus/pull/1079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org