You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2018/03/22 16:10:12 UTC
[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9758
Change subject: IMPALA-6715: fix stress TPC workload selection
......................................................................
IMPALA-6715: fix stress TPC workload selection
A recent commit caused the stress test to double-count queries. This
makes the binary search run incredibly slow.
- Fix the query selection. Add additional queries that weren't matching
before, like the tpcds-q[0-9]+a.test series.
- Add a test that will at least ensure if
testdata/workloads/tpc*/queries is modified, the stress test will
still find the same number of queries for the given workload. There's
no obvious place to put this test: it's not testing the product at
all, so:
- Add a new directory tests/infra for such tests and add it to
tests/run-tests.py.
- Move the test from IMPALA-6441 into tests/infra.
Testing:
- Core private build passed. I manually looked to make sure the moved
and new tests ran.
- Short stress test run. I checked the runtime info and saw the new
TPCDS queries in the JSON.
Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
---
A tests/infra/test_infra.py
M tests/metadata/test_explain.py
M tests/run-tests.py
M tests/stress/concurrent_select.py
4 files changed, 75 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/9758/1
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715: fix stress TPC workload selection
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/infra/test_infra.py
File tests/infra/test_infra.py:
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/infra/test_infra.py@1
PS1, Line 1: # Licensed to the Apache Software Foundation (ASF) under one
This is awesome. We've needed a place to have tests for the infra code for a long time.
Maybe I'm a just crazy dreamer, but someday the contents of this directory might grow. Maybe this file should be renamed test_stress_infra.py, with the hope that it will have siblings someday.
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py@91
PS1, Line 91: 71
Why is this number so low? When I list the contents of tpch and tpch_nested workload directories, the number of files matches (22).
$ ls -l workloads/tpch/queries/*-q*test | wc -l
22
$ ls -l workloads/tpch_nested/queries/*-q*test | wc -l
22
$ ls -l workloads/tpcds/queries/*-q*test | wc -l
143
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Mar 2018 20:51:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715: fix stress TPC workload selection
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/infra/test_infra.py
File tests/infra/test_infra.py:
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/infra/test_infra.py@1
PS1, Line 1: # Licensed to the Apache Software Foundation (ASF) under one
> This is awesome. We've needed a place to have tests for the infra code for
Done
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py@91
PS1, Line 91: 71
> Why is this number so low? When I list the contents of tpch and tpch_nested
Your matching isn't right ;). There are duplicate decimal_v2 queries, hence the bug and the double-counting. Really, when those were added, I should have asked to make them a separate workload.
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Mar 2018 16:31:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello Nithya Janarthanan, David Knupp, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9758
to look at the new patch set (#2).
Change subject: IMPALA-6715: fix stress TPC workload selection
......................................................................
IMPALA-6715: fix stress TPC workload selection
A recent commit caused the stress test to double-count queries. This
makes the binary search run incredibly slow.
- Fix the query selection. Add additional queries that weren't matching
before, like the tpcds-q[0-9]+a.test series.
- Add a test that will at least ensure if
testdata/workloads/tpc*/queries is modified, the stress test will
still find the same number of queries for the given workload. There's
no obvious place to put this test: it's not testing the product at
all, so:
- Add a new directory tests/infra for such tests and add it to
tests/run-tests.py.
- Move the test from IMPALA-6441 into tests/infra.
Testing:
- Core private build passed. I manually looked to make sure the moved
and new tests ran.
- Short stress test run. I checked the runtime info and saw the new
TPCDS queries in the JSON.
Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
---
A tests/infra/test_stress_infra.py
M tests/metadata/test_explain.py
M tests/run-tests.py
M tests/stress/concurrent_select.py
4 files changed, 75 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/9758/2
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 22:26:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9758/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9758/4//COMMIT_MSG@37
PS4, Line 37: - While testing on hardware clusters down stream, I noticed IMPALA-6736:
> Nit: since you've set up IMPALA-6715 as a "sub-header" of sorts, for symmet
Done
http://gerrit.cloudera.org:8080/#/c/9758/4/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9758/4/tests/stress/concurrent_select.py@2071
PS4, Line 2071: Filtering non-spilling query due to mem ratio option
> Nt:
Done
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 18:34:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
......................................................................
Patch Set 4:
(2 comments)
Feel free to commit
http://gerrit.cloudera.org:8080/#/c/9758/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9758/4//COMMIT_MSG@37
PS4, Line 37: - While testing on hardware clusters down stream, I noticed IMPALA-6736:
Nit: since you've set up IMPALA-6715 as a "sub-header" of sorts, for symmetry, maybe do the same with IMPALA-6736.
http://gerrit.cloudera.org:8080/#/c/9758/4/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9758/4/tests/stress/concurrent_select.py@2071
PS4, Line 2071: Filtering non-spilling query due to mem ratio option
Nt:
"Filtering non-spilling query that exceeds mem ratio option"
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 18:25:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello Nithya Janarthanan, David Knupp, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9758
to look at the new patch set (#5).
Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
......................................................................
IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
IMPALA-6715:
This commit
IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL
added additional decimal_v2 queries to the stress test that amount to
running the same query twice. This makes the binary search run
incredibly slow.
- Fix the query selection. Add additional queries that weren't matching
before, like the tpcds-q[0-9]+a.test series.
- Add a test that will at least ensure if
testdata/workloads/tpc*/queries is modified, the stress test will
still find the same number of queries for the given workload. There's
no obvious place to put this test: it's not testing the product at
all, so:
- Add a new directory tests/infra for such tests and add it to
tests/run-tests.py.
- Move the test from IMPALA-6441 into tests/infra.
Testing:
- Core private build passed. I manually looked to make sure the moved
and new tests ran.
- Short stress test run. I checked the runtime info and saw the new
TPCDS queries in the JSON.
- While testing on hardware clusters down stream, I noticed...
IMPALA-6736:
TPC-DS Q67A is 10x more expensive to run without spilling than any
other query. I fixed the --filter-query-mem-ratio option to work. This
will still run Q67A during the binary search phase, but if a cluster
is too small, the query will be skipped.
Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
---
A tests/infra/test_stress_infra.py
M tests/metadata/test_explain.py
M tests/run-tests.py
M tests/stress/concurrent_select.py
4 files changed, 88 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/9758/5
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
......................................................................
Patch Set 4:
PS4 fixes another bug which would be a blocker for this patch. Please take another look. Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Mar 2018 22:36:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715: fix stress TPC workload selection
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Mar 2018 16:07:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
......................................................................
Patch Set 5: Code-Review+2
Sorry, meant to complete my last sentence and add a +2 with my last comment, but I clicked "Send" instead by accident.
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 18:37:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello Nithya Janarthanan, David Knupp, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9758
to look at the new patch set (#3).
Change subject: IMPALA-6715: fix stress TPC workload selection
......................................................................
IMPALA-6715: fix stress TPC workload selection
This commit
IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL
added additional decimal_v2 queries to the stress test that amount to
running the same query twice. This makes the binary search run
incredibly slow.
- Fix the query selection. Add additional queries that weren't matching
before, like the tpcds-q[0-9]+a.test series.
- Add a test that will at least ensure if
testdata/workloads/tpc*/queries is modified, the stress test will
still find the same number of queries for the given workload. There's
no obvious place to put this test: it's not testing the product at
all, so:
- Add a new directory tests/infra for such tests and add it to
tests/run-tests.py.
- Move the test from IMPALA-6441 into tests/infra.
Testing:
- Core private build passed. I manually looked to make sure the moved
and new tests ran.
- Short stress test run. I checked the runtime info and saw the new
TPCDS queries in the JSON.
Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
---
A tests/infra/test_stress_infra.py
M tests/metadata/test_explain.py
M tests/run-tests.py
M tests/stress/concurrent_select.py
4 files changed, 78 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/9758/3
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2174/
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 18:38:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
......................................................................
IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
IMPALA-6715:
This commit
IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL
added additional decimal_v2 queries to the stress test that amount to
running the same query twice. This makes the binary search run
incredibly slow.
- Fix the query selection. Add additional queries that weren't matching
before, like the tpcds-q[0-9]+a.test series.
- Add a test that will at least ensure if
testdata/workloads/tpc*/queries is modified, the stress test will
still find the same number of queries for the given workload. There's
no obvious place to put this test: it's not testing the product at
all, so:
- Add a new directory tests/infra for such tests and add it to
tests/run-tests.py.
- Move the test from IMPALA-6441 into tests/infra.
Testing:
- Core private build passed. I manually looked to make sure the moved
and new tests ran.
- Short stress test run. I checked the runtime info and saw the new
TPCDS queries in the JSON.
- While testing on hardware clusters down stream, I noticed...
IMPALA-6736:
TPC-DS Q67A is 10x more expensive to run without spilling than any
other query. I fixed the --filter-query-mem-ratio option to work. This
will still run Q67A during the binary search phase, but if a cluster
is too small, the query will be skipped.
Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Reviewed-on: http://gerrit.cloudera.org:8080/9758
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Impala Public Jenkins
---
A tests/infra/test_stress_infra.py
M tests/metadata/test_explain.py
M tests/run-tests.py
M tests/stress/concurrent_select.py
4 files changed, 88 insertions(+), 27 deletions(-)
Approvals:
David Knupp: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715: fix stress TPC workload selection
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9758/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9758/1//COMMIT_MSG@9
PS1, Line 9: A recent commit caused the stress test to double-count queries. This
> By this comment, I'm taking that you mean the addition of the tpcds-decimal
Done
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py@91
PS1, Line 91: 71
> After our conversation yesterday, I understood this to be the case. Should
Imo it just falls under the umbrella of IMPALA-3947.
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py@1076
PS1, Line 1076: file_name_pattern = re.compile(r"^{0}-(q.*).test$".format(workload))
> Can you add a comment explaining why this is necessary -- e.g., that there
Done
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Mar 2018 22:37:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello Nithya Janarthanan, David Knupp, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9758
to look at the new patch set (#4).
Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
......................................................................
IMPALA-6715,IMPALA-6736: fix stress TPC workload selection
IMPALA-6715:
This commit
IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL
added additional decimal_v2 queries to the stress test that amount to
running the same query twice. This makes the binary search run
incredibly slow.
- Fix the query selection. Add additional queries that weren't matching
before, like the tpcds-q[0-9]+a.test series.
- Add a test that will at least ensure if
testdata/workloads/tpc*/queries is modified, the stress test will
still find the same number of queries for the given workload. There's
no obvious place to put this test: it's not testing the product at
all, so:
- Add a new directory tests/infra for such tests and add it to
tests/run-tests.py.
- Move the test from IMPALA-6441 into tests/infra.
Testing:
- Core private build passed. I manually looked to make sure the moved
and new tests ran.
- Short stress test run. I checked the runtime info and saw the new
TPCDS queries in the JSON.
- While testing on hardware clusters down stream, I noticed IMPALA-6736:
TPC-DS Q67A is 10x more expensive to run without spilling than any
other query. I fixed the --filter-query-mem-ratio option to work. This
will still run Q67A during the binary search phase, but if a cluster
is too small, the query will be skipped.
Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
---
A tests/infra/test_stress_infra.py
M tests/metadata/test_explain.py
M tests/run-tests.py
M tests/stress/concurrent_select.py
4 files changed, 84 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/9758/4
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715: fix stress TPC workload selection
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9758/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9758/1//COMMIT_MSG@9
PS1, Line 9: A recent commit caused the stress test to double-count queries. This
By this comment, I'm taking that you mean the addition of the tpcds-decimal-* queries. Can you actually reference that commit here, and say that queries were added to the workload that don't apply to the stress test? As is, I read this to mean that a bug had been introduced into the stress test that was literally causing it to process the same query files twice as many times as necessary.
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py@91
PS1, Line 91: 71
> Your matching isn't right ;). There are duplicate decimal_v2 queries, hence
After our conversation yesterday, I understood this to be the case. Should we file a JIRA to move them to a separate workload?
http://gerrit.cloudera.org:8080/#/c/9758/1/tests/stress/concurrent_select.py@1076
PS1, Line 1076: file_name_pattern = re.compile(r"^{0}-(q.*).test$".format(workload))
Can you add a comment explaining why this is necessary -- e.g., that there are queries (e.g., decimal_v2) in the TPCDS workload/queries directory that the stress test should overlook. Reference the JIRA re: creating a new workload if you filed one.
--
To view, visit http://gerrit.cloudera.org:8080/9758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da
Gerrit-Change-Number: 9758
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Mar 2018 18:23:08 +0000
Gerrit-HasComments: Yes