You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "valepakh (via GitHub)" <gi...@apache.org> on 2025/02/04 09:42:47 UTC
[PR] IGNITE-24071 Introduce the new value for REPLICAS parameter into CREATE ZONE and ALTER ZONE commands [ignite-3]
valepakh opened a new pull request, #5167:
URL: https://github.com/apache/ignite-3/pull/5167
https://issues.apache.org/jira/browse/IGNITE-24071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24071 Introduce the new value for REPLICAS parameter into CREATE ZONE and ALTER ZONE commands [ignite-3]
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #5167:
URL: https://github.com/apache/ignite-3/pull/5167#discussion_r1943013731
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##########
@@ -197,6 +205,8 @@ public DdlSqlToCommandConverter() {
DATA_NODES_AUTO_ADJUST_SCALE_DOWN,
new DdlOptionInfo<>(Integer.class, this::checkPositiveNumber, AlterZoneCommandBuilder::dataNodesAutoAdjustScaleDown)
));
+
+ alterReplicasOptionInfo = new DdlOptionInfo<>(Integer.class, this::checkPositiveNumber, AlterZoneCommandBuilder::replicas);
Review Comment:
Why do you need to have two instances of DdlOptionsInfor for CREATE and ALTER? Are they supposed to be different over time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24071 Introduce the new value for REPLICAS parameter into CREATE ZONE and ALTER ZONE commands [ignite-3]
Posted by "valepakh (via GitHub)" <gi...@apache.org>.
valepakh commented on code in PR #5167:
URL: https://github.com/apache/ignite-3/pull/5167#discussion_r1943030018
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##########
@@ -197,6 +205,8 @@ public DdlSqlToCommandConverter() {
DATA_NODES_AUTO_ADJUST_SCALE_DOWN,
new DdlOptionInfo<>(Integer.class, this::checkPositiveNumber, AlterZoneCommandBuilder::dataNodesAutoAdjustScaleDown)
));
+
+ alterReplicasOptionInfo = new DdlOptionInfo<>(Integer.class, this::checkPositiveNumber, AlterZoneCommandBuilder::replicas);
Review Comment:
Because they have a different setters
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##########
@@ -197,6 +205,8 @@ public DdlSqlToCommandConverter() {
DATA_NODES_AUTO_ADJUST_SCALE_DOWN,
new DdlOptionInfo<>(Integer.class, this::checkPositiveNumber, AlterZoneCommandBuilder::dataNodesAutoAdjustScaleDown)
));
+
+ alterReplicasOptionInfo = new DdlOptionInfo<>(Integer.class, this::checkPositiveNumber, AlterZoneCommandBuilder::replicas);
Review Comment:
Because they have different setters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-24071 Introduce the new value for REPLICAS parameter into CREATE ZONE and ALTER ZONE commands [ignite-3]
Posted by "Pochatkin (via GitHub)" <gi...@apache.org>.
Pochatkin merged PR #5167:
URL: https://github.com/apache/ignite-3/pull/5167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org