You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/17 12:18:00 UTC
[jira] [Commented] (CB-13291) Statusbar does not overlay correctly
for iOS 11 and iPhone X
[ https://issues.apache.org/jira/browse/CB-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169273#comment-16169273 ]
ASF GitHub Bot commented on CB-13291:
-------------------------------------
GitHub user BrainstemStudio opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/86
CB-13291: iOS 11 statusbar fixes
1. Added new property "StatusBarCropsWebview" to allow iPhone X to display edge to edge using the "safeAreaInsets" top and bottom. By default this will be set as "true" and crop the webview below and above the safe areas
2. When "StatusBarCropsWebview" is set to false. The web view will extend to the correcr full screen on iPhone X. However, is the "StatusBarOverlaysWebView" is to false. This will only extend the web view at the bottom edge
3. If both StatusBarCropsWebview and “StatusBarOverlaysWebView” are set to false this will extend the screen top and bottom edge.
4. Added fix for iOS 11 gap problems. If “StatusBarOverlaysWebView” is set to false, this now fixes the 20px bottom gap.
5. Added fix for iOS 11 gap after status bar is set to hidden after showing. This now fixes the 20px bottom gap.
6. Added fix for iPad to force web view status bar to not run if app for iPhone but running on iPad. Requirement from apple.
See https://issues.apache.org/jira/browse/CB-13291 for full details
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BrainstemStudio/cordova-plugin-statusbar CB-13291
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-statusbar/pull/86.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #86
----
commit b2e83b26f12b68a5d504d2ba171d7fcb1e1d19a7
Author: BrainstemStudio <ma...@brainstemstudio.com>
Date: 2017-09-17T11:31:58Z
CB-13291: Fixes
1. Added new property "StatusBarCropsWebview" to allow iPhone X to display edge to edge using the "safeAreaInsets" top and bottom. By default this will be set as "true" and crop the webview below and above the safe areas
2. When "StatusBarCropsWebview" is set to false. The web view will extend to the correcr full screen on iPhone X. However, is the "StatusBarOverlaysWebView" is to false. This will only extend the web view at the bottom edge
3. If both StatusBarCropsWebview and “StatusBarOverlaysWebView” are set to false this will extend the screen top and bottom edge.
4. Added fix for iOS 11 gap problems. If “StatusBarOverlaysWebView” is set to false, this now fixes the 20px bottom gap.
5. Added fix for iOS 11 gap after status bar is set to hidden after showing. This now fixes the 20px bottom gap.
See https://issues.apache.org/jira/browse/CB-13291 for full details
----
> Statusbar does not overlay correctly for iOS 11 and iPhone X
> ------------------------------------------------------------
>
> Key: CB-13291
> URL: https://issues.apache.org/jira/browse/CB-13291
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-statusbar
> Affects Versions: cordova-ios 4.5.0
> Environment: iOS 11
> Reporter: Sean Molyneaux
> Labels: iOS11, iPhoneX
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Status Bar iOS 11 issues:
> # Status Bar does not "crop" correctly on iOS 11 when "StatusBarOverlaysWebView" is set to true
> # No property or support to allow for web view to use the whole iPhone X screen Top & Bottom
> Recommendation:
> # Use safeAreaInsets to correctly adjust iOS 11 web view correctly
> # Allow new property to support iPhone X full screen
> Fixes applied (Pending Review)
> #Added new property "StatusBarCropsWebview" to allow iPhone X to display edge to edge using the "safeAreaInsets" top and bottom. By default this will be set as "true" and crop the webview below and above the safe areas
> #When "StatusBarCropsWebview" is set to false. The web view will extend to the correcr full screen on iPhone X. However, is the "StatusBarOverlaysWebView" is to false. This will only extend the web view at the bottom edge
> #If both StatusBarCropsWebview and “StatusBarOverlaysWebView” are set to false this will extend the screen top and bottom edge.
> #Added fix for iOS 11 gap problems. If “StatusBarOverlaysWebView” is set to false, this now fixes the 20px bottom gap.
> #Added fix for iOS 11 gap after status bar is set to hidden after showing. This now fixes the 20px bottom gap.
> Screenshots of Fixes:
> 1. Default where StatusBarCropsWebview = true and StatusBarOverlaysWebView = false
> !http://brainstemstudio.com/labs/cordova/patches/statusbar/statusbar-1.png!
> 2. Where StatusBarCropsWebview = false and StatusBarOverlaysWebView = true
> !http://brainstemstudio.com/labs/cordova/patches/statusbar/statusbar-2.png!
> 3. Where StatusBarCropsWebview = false and StatusBarOverlaysWebView = true
> !http://brainstemstudio.com/labs/cordova/patches/statusbar/statusbar-3.png!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org