You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "coderzc (via GitHub)" <gi...@apache.org> on 2023/08/28 08:02:28 UTC

[GitHub] [pulsar] coderzc commented on pull request #21065: [improve][broker] Make read compacted entries support maxReadSizeBytes limitation

coderzc commented on PR #21065:
URL: https://github.com/apache/pulsar/pull/21065#issuecomment-1695226358

   `org.apache.pulsar.compaction.StrategicCompactionTest.testCompactCompressedBatching` always failed after applying this change. I noticed the StrategicTwoPhaseCompactor may write messages from the same batch into different entries, which will result in skipping some messages when reading compacted entries. Is that so?
   Refer to: https://github.com/apache/pulsar/blob/d099ac4fa2f217b9c5f0a5e660c83048e829c5d7/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java#L129-L135 
   
   https://github.com/apache/pulsar/blob/d099ac4fa2f217b9c5f0a5e660c83048e829c5d7/pulsar-broker/src/main/java/org/apache/pulsar/compaction/StrategicTwoPhaseCompactor.java#L444-L455
   /cc @heesung-sn @Demogorgon314 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org