You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Eks Dev (JIRA)" <ji...@apache.org> on 2009/04/27 22:23:30 UTC

[jira] Created: (LUCENE-1619) TermAttribute.termLength() optimization

TermAttribute.termLength() optimization
---------------------------------------

                 Key: LUCENE-1619
                 URL: https://issues.apache.org/jira/browse/LUCENE-1619
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Analysis
            Reporter: Eks Dev
            Priority: Trivial
         Attachments: LUCENE-1619.patch


   public int termLength() {
     initTermBuffer(); // This patch removes this method call 
     return termLength;
   }

I see no reason to initTermBuffer() in termLength()... all tests pass, but I could be wrong?



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1619) TermAttribute.termLength() optimization

Posted by "Eks Dev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703543#action_12703543 ] 

Eks Dev commented on LUCENE-1619:
---------------------------------

thanks Mike

> TermAttribute.termLength() optimization
> ---------------------------------------
>
>                 Key: LUCENE-1619
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1619
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Eks Dev
>            Assignee: Michael McCandless
>            Priority: Trivial
>             Fix For: 2.9
>
>         Attachments: LUCENE-1619.patch
>
>
>    public int termLength() {
>      initTermBuffer(); // This patch removes this method call 
>      return termLength;
>    }
> I see no reason to initTermBuffer() in termLength()... all tests pass, but I could be wrong?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Assigned: (LUCENE-1619) TermAttribute.termLength() optimization

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless reassigned LUCENE-1619:
------------------------------------------

    Assignee: Michael McCandless

> TermAttribute.termLength() optimization
> ---------------------------------------
>
>                 Key: LUCENE-1619
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1619
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Eks Dev
>            Assignee: Michael McCandless
>            Priority: Trivial
>         Attachments: LUCENE-1619.patch
>
>
>    public int termLength() {
>      initTermBuffer(); // This patch removes this method call 
>      return termLength;
>    }
> I see no reason to initTermBuffer() in termLength()... all tests pass, but I could be wrong?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1619) TermAttribute.termLength() optimization

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703537#action_12703537 ] 

Michael McCandless commented on LUCENE-1619:
--------------------------------------------

Indeed it seems unnecessary -- I'll commit.  Thanks Eks!

> TermAttribute.termLength() optimization
> ---------------------------------------
>
>                 Key: LUCENE-1619
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1619
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Eks Dev
>            Assignee: Michael McCandless
>            Priority: Trivial
>         Attachments: LUCENE-1619.patch
>
>
>    public int termLength() {
>      initTermBuffer(); // This patch removes this method call 
>      return termLength;
>    }
> I see no reason to initTermBuffer() in termLength()... all tests pass, but I could be wrong?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1619) TermAttribute.termLength() optimization

Posted by "Eks Dev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eks Dev updated LUCENE-1619:
----------------------------

    Attachment: LUCENE-1619.patch

> TermAttribute.termLength() optimization
> ---------------------------------------
>
>                 Key: LUCENE-1619
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1619
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Eks Dev
>            Priority: Trivial
>         Attachments: LUCENE-1619.patch
>
>
>    public int termLength() {
>      initTermBuffer(); // This patch removes this method call 
>      return termLength;
>    }
> I see no reason to initTermBuffer() in termLength()... all tests pass, but I could be wrong?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1619) TermAttribute.termLength() optimization

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1619.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.9

> TermAttribute.termLength() optimization
> ---------------------------------------
>
>                 Key: LUCENE-1619
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1619
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Eks Dev
>            Assignee: Michael McCandless
>            Priority: Trivial
>             Fix For: 2.9
>
>         Attachments: LUCENE-1619.patch
>
>
>    public int termLength() {
>      initTermBuffer(); // This patch removes this method call 
>      return termLength;
>    }
> I see no reason to initTermBuffer() in termLength()... all tests pass, but I could be wrong?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org