You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/18 08:01:10 UTC

[GitHub] [airflow] eladkal opened a new pull request #21662: Add ALL_SKIPPED trigger rule

eladkal opened a new pull request #21662:
URL: https://github.com/apache/airflow/pull/21662


   closes: https://github.com/apache/airflow/issues/16951
   
   Example:
   ![Screen Shot 2022-02-18 at 9 56 21](https://user-images.githubusercontent.com/45845474/154641484-488dbd86-3057-4d19-97a2-c8c504db9b95.png)
   
   
   If you wish to test locally you can use:
   ```
   from datetime import datetime
   
   from airflow import DAG
   from airflow.decorators import task
   from airflow.exceptions import AirflowSkipException
   from airflow.operators.dummy import DummyOperator
   
   with DAG(
       dag_id"trigger",
       start_date=datetime(2022, 6, 7),
       schedule_interval=None,
   ) as dag:
       start = DummyOperator(task_id='start')
       final = DummyOperator(task_id='final', trigger_rule='all_skipped')
   
       for i in range(3):
           @task(task_id=f"skip_{i}")
           def execute():
               raise AirflowSkipException
           start >> execute() >> final
   ```
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #21662: Add ALL_SKIPPED trigger rule

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21662:
URL: https://github.com/apache/airflow/pull/21662


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on pull request #21662: Add ALL_SKIPPED trigger rule

Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #21662:
URL: https://github.com/apache/airflow/pull/21662#issuecomment-1046244216


   Rebased and solved conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] yuqian90 commented on pull request #21662: Add ALL_SKIPPED trigger rule

Posted by GitBox <gi...@apache.org>.
yuqian90 commented on pull request #21662:
URL: https://github.com/apache/airflow/pull/21662#issuecomment-1058669265


   Is `NONE_FAILED` not sufficient for this purpose? The difference between `NONE_FAILED` and `NONE_FAILED_MIN_ONE_SUCCESS` is that `NONE_FAILED` runs even when all upstream tasks are skipped.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org