You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "bereng (via GitHub)" <gi...@apache.org> on 2023/09/18 07:33:33 UTC
[GitHub] [cassandra] bereng opened a new pull request, #2696: IDEA to mark unused imports as error
bereng opened a new pull request, #2696:
URL: https://github.com/apache/cassandra/pull/2696
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #2696: IDEA to mark unused imports as error
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on PR #2696:
URL: https://github.com/apache/cassandra/pull/2696#issuecomment-1723219975
I saw your comment and then your own response to which I agree so I didn't reply lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on pull request #2696: IDEA to mark unused imports as error
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on PR #2696:
URL: https://github.com/apache/cassandra/pull/2696#issuecomment-1723039694
https://issues.apache.org/jira/browse/CASSANDRA-18853?focusedCommentId=17766263&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17766263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #2696: IDEA to mark unused imports as error
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on PR #2696:
URL: https://github.com/apache/cassandra/pull/2696#issuecomment-1723017227
^Sbdy with the IDE should test it :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jacek-lewandowski commented on pull request #2696: IDEA to mark unused imports as error
Posted by "jacek-lewandowski (via GitHub)" <gi...@apache.org>.
jacek-lewandowski commented on PR #2696:
URL: https://github.com/apache/cassandra/pull/2696#issuecomment-1722998772
+1, should such update be done also for Eclipse/Netbeans configuration (I don't know if anybody still uses that though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #2696: IDEA to mark unused imports as error
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on PR #2696:
URL: https://github.com/apache/cassandra/pull/2696#issuecomment-1723056263
Sorry not follwoing @smiklosovic, why that link to a comment in the ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng closed pull request #2696: IDEA to mark unused imports as error
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng closed pull request #2696: IDEA to mark unused imports as error
URL: https://github.com/apache/cassandra/pull/2696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #2696: IDEA to mark unused imports as error
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on PR #2696:
URL: https://github.com/apache/cassandra/pull/2696#issuecomment-1722912526
CI builds [green](https://app.circleci.com/pipelines/github/bereng/cassandra/1067/workflows/1d005c8c-c1c4-4036-94c4-fe699cf4ec12/jobs/28738). No need to add junit imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on pull request #2696: IDEA to mark unused imports as error
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on PR #2696:
URL: https://github.com/apache/cassandra/pull/2696#issuecomment-1723098598
@bereng because I clearly see that you are debating this PR but I got no response on the ticket so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org