You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dpogue <gi...@git.apache.org> on 2016/10/06 19:58:08 UTC
[GitHub] cordova-android pull request #340: CB-8722 - Move app icons from drawable to...
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-android/pull/340
CB-8722 - Move app icons from drawable to mipmap
https://issues.apache.org/jira/browse/CB-8722
Reasoning behind the change: https://androidbycode.wordpress.com/2015/02/14/goodbye-launcher-drawables-hello-mipmaps/
/cc @infil00p
This probably counts as a breaking change, so we might want to get this into 6.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-android mipmap
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #340
----
commit 97855018e9aeb955f3dd7e31c91fb6b8f67e0c29
Author: Darryl Pogue <da...@ayogo.com>
Date: 2016-10-06T19:55:26Z
CB-8722 - Move icons from drawable to mipmap
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the issue:
https://github.com/apache/cordova-android/pull/340
That is a known issue with cordova-android@6.0.0, unrelated to this change.
It has been fixed in master, and will be included in cordova-android@6.1.0 which is due to be released this week or next.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the issue:
https://github.com/apache/cordova-android/pull/340
If they were specifying icons via config.xml, this should just work.
If they had the platform already installed and had modified files, this shouldn't affect those existing files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #340: CB-8722 - Move app icons from drawable to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Posted by ghenry22 <gi...@git.apache.org>.
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-android/pull/340
I have the same problem, after upgrading the platform I now get default cordova icons for my android build, even though with the previous version of the platform all icons and splash screen images were in place and all specified in config.xml.
I use ionic framework to auto generate all splash / icon images and insert them into the config.xml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/340
## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/340?src=pr) is 35.15% (diff: 100%)
> Merging [#340](https://codecov.io/gh/apache/cordova-android/pull/340?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage
```diff
@@ master #340 diff @@
==========================================
Files 12 12
Lines 1007 1007
Methods 198 198
Messages 0 0
Branches 168 168
==========================================
Hits 354 354
Misses 653 653
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [37384c5...9785501](https://codecov.io/gh/apache/cordova-android/compare/37384c583d5a2e5b9b5c5d2cbf150f07f329d16c...97855018e9aeb955f3dd7e31c91fb6b8f67e0c29?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/340
If someone knew nothing about Android, and they just fiddled with their icons, would this change, or would we have to delete their old drawable for this to work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap
Posted by AxelNennker <gi...@git.apache.org>.
Github user AxelNennker commented on the issue:
https://github.com/apache/cordova-android/pull/340
Does not work for me. Steps to reproduce are in the CB-8722
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org