You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/24 05:07:16 UTC
[GitHub] [rocketmq-streams] hyl-xidian opened a new pull request, #173: [ISSUE #172]Modify the File Source Example and update the README.md
hyl-xidian opened a new pull request, #173:
URL: https://github.com/apache/rocketmq-streams/pull/173
Add a filter usage example and modify the document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] hyl-xidian commented on pull request #173: [ISSUE #172]Modify the File Source Example and update the README.md
Posted by GitBox <gi...@apache.org>.
hyl-xidian commented on PR #173:
URL: https://github.com/apache/rocketmq-streams/pull/173#issuecomment-1165219553
#174 fix incompatible types bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] codecov-commenter commented on pull request #173: [ISSUE #172]Modify the File Source Example and update the README.md
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #173:
URL: https://github.com/apache/rocketmq-streams/pull/173#issuecomment-1165213227
# [Codecov](https://codecov.io/gh/apache/rocketmq-streams/pull/173?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#173](https://codecov.io/gh/apache/rocketmq-streams/pull/173?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77db264) into [main](https://codecov.io/gh/apache/rocketmq-streams/commit/dcd0c770c21eacf6132d0249b000aec03b716888?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcd0c77) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #173 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 712 712
Lines 35567 35563 -4
Branches 5928 5922 -6
=====================================
+ Misses 35567 35563 -4
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-streams/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tmq/streams/common/context/UserDefinedMessage.java](https://codecov.io/gh/apache/rocketmq-streams/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cm9ja2V0bXEtc3RyZWFtcy1jb21tb25zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zdHJlYW1zL2NvbW1vbi9jb250ZXh0L1VzZXJEZWZpbmVkTWVzc2FnZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...eams/examples/aggregate/RocketMQWindowExample.java](https://codecov.io/gh/apache/rocketmq-streams/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cm9ja2V0bXEtc3RyZWFtcy1leGFtcGxlcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9leGFtcGxlcy9hZ2dyZWdhdGUvUm9ja2V0TVFXaW5kb3dFeGFtcGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...s/examples/checkpoint/RemoteCheckpointExample.java](https://codecov.io/gh/apache/rocketmq-streams/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cm9ja2V0bXEtc3RyZWFtcy1leGFtcGxlcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9leGFtcGxlcy9jaGVja3BvaW50L1JlbW90ZUNoZWNrcG9pbnRFeGFtcGxlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ms/examples/mutilconsumer/MultiStreamsExample.java](https://codecov.io/gh/apache/rocketmq-streams/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cm9ja2V0bXEtc3RyZWFtcy1leGFtcGxlcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9leGFtcGxlcy9tdXRpbGNvbnN1bWVyL011bHRpU3RyZWFtc0V4YW1wbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ketmq/streams/examples/mutilconsumer/Producer.java](https://codecov.io/gh/apache/rocketmq-streams/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cm9ja2V0bXEtc3RyZWFtcy1leGFtcGxlcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9leGFtcGxlcy9tdXRpbGNvbnN1bWVyL1Byb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...tmq/streams/examples/source/FileSourceExample.java](https://codecov.io/gh/apache/rocketmq-streams/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cm9ja2V0bXEtc3RyZWFtcy1leGFtcGxlcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9leGFtcGxlcy9zb3VyY2UvRmlsZVNvdXJjZUV4YW1wbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...treams/examples/source/RocketmqSourceExample1.java](https://codecov.io/gh/apache/rocketmq-streams/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cm9ja2V0bXEtc3RyZWFtcy1leGFtcGxlcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9leGFtcGxlcy9zb3VyY2UvUm9ja2V0bXFTb3VyY2VFeGFtcGxlMS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...treams/examples/source/RocketmqSourceExample2.java](https://codecov.io/gh/apache/rocketmq-streams/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cm9ja2V0bXEtc3RyZWFtcy1leGFtcGxlcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9leGFtcGxlcy9zb3VyY2UvUm9ja2V0bXFTb3VyY2VFeGFtcGxlMi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...treams/examples/source/RocketmqSourceExample3.java](https://codecov.io/gh/apache/rocketmq-streams/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cm9ja2V0bXEtc3RyZWFtcy1leGFtcGxlcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9leGFtcGxlcy9zb3VyY2UvUm9ja2V0bXFTb3VyY2VFeGFtcGxlMy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...treams/examples/source/RocketmqSourceExample4.java](https://codecov.io/gh/apache/rocketmq-streams/pull/173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cm9ja2V0bXEtc3RyZWFtcy1leGFtcGxlcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9leGFtcGxlcy9zb3VyY2UvUm9ja2V0bXFTb3VyY2VFeGFtcGxlNC5qYXZh) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-streams/pull/173?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-streams/pull/173?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f8f755e...77db264](https://codecov.io/gh/apache/rocketmq-streams/pull/173?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] hyl-xidian commented on pull request #173: [ISSUE #172][ISSUE #174]Modify the File Source Example; Update README; Fix incompatible types bug
Posted by GitBox <gi...@apache.org>.
hyl-xidian commented on PR #173:
URL: https://github.com/apache/rocketmq-streams/pull/173#issuecomment-1166835582
> @hyl-xidian can you remove the fix bug part? The others looks fine to me.
Got it, I have removed the fix bug part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze merged pull request #173: [ISSUE #172][ISSUE #174]Modify the File Source Example; Update README; Fix incompatible types bug
Posted by GitBox <gi...@apache.org>.
ni-ze merged PR #173:
URL: https://github.com/apache/rocketmq-streams/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #173: [ISSUE #172][ISSUE #174]Modify the File Source Example; Update README; Fix incompatible types bug
Posted by GitBox <gi...@apache.org>.
ni-ze commented on PR #173:
URL: https://github.com/apache/rocketmq-streams/pull/173#issuecomment-1166829143
@hyl-xidian can you remove the fix bug part? The others looks fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on a diff in pull request #173: [ISSUE #172][ISSUE #174]Modify the File Source Example; Update README; Fix incompatible types bug
Posted by GitBox <gi...@apache.org>.
ni-ze commented on code in PR #173:
URL: https://github.com/apache/rocketmq-streams/pull/173#discussion_r906946373
##########
rocketmq-streams-commons/src/main/java/org/apache/rocketmq/streams/common/context/UserDefinedMessage.java:
##########
@@ -318,12 +318,12 @@ public Date getDate(String key) {
@Override
public java.sql.Date getSqlDate(String key) {
- return super.getSqlDate(key);
+ return (java.sql.Date) super.getSqlDate(key);
Review Comment:
It is cause by update fastjson version, and I fixed it by changed the return type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #173: [ISSUE #172][ISSUE #174]Modify the File Source Example; Update README; Fix incompatible types bug
Posted by GitBox <gi...@apache.org>.
ni-ze commented on PR #173:
URL: https://github.com/apache/rocketmq-streams/pull/173#issuecomment-1166825479
https://github.com/apache/rocketmq-streams/issues/172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org