[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #9366: [CI] try to fix ci

[GitBox <gi...@apache.org>]

kezhenxu94 commented on code in PR #9366:
URL: https://github.com/apache/dolphinscheduler/pull/9366#discussion_r843803071


##########
.github/workflows/backend.yml:
##########
@@ -81,13 +81,15 @@ jobs:
     name: Build
     runs-on: ubuntu-latest
     timeout-minutes: 30
-    needs: [ build ]
+    needs: [ build, paths-filter ]

Review Comment:
   As [I said](https://github.com/apache/dolphinscheduler/pull/9325#discussion_r843403142) we don't need this?



##########
.github/workflows/backend.yml:
##########
@@ -81,13 +81,15 @@ jobs:
     name: Build
     runs-on: ubuntu-latest
     timeout-minutes: 30
-    needs: [ build ]
+    needs: [ build, paths-filter ]
     if: always()
     steps:
       - name: Status
         run: |
-          if [[ ${{ needs.build.result }} == 'success' || ${{ needs.paths-filter.outputs.ignore == 'true' }} ]]; then
+          if [[ ${{ needs.build.result }} == 'success' ]]; then
             echo "Passed!"
+          elif [[ ${{ needs.paths-filter.outputs.not-ignore }} == 'false' ]]; then
+            echo "Skip Build!"
           else
             exit -1
           fi

Review Comment:
   Do you think this 👇 would be easier to understand?
   
   ```suggestion
             if [[ ${{ needs.paths-filter.outputs.ignore }} == 'true' ]]; then
               echo "Skip Build!"
               exit 0
             fi
             if [[ ${{ needs.build.result }} != 'success' ]]; then
               echo "Failed to build"
               exit -1
             fi
             # If we need to add more condition in the future, we can simply add
             if [[ ${{ needs.new.condition.result }} != 'success' ]]; then
               echo "Failed to do some new stuff"
               exit -1
             fi
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org