You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/09/18 15:47:00 UTC

[jira] [Commented] (AIRFLOW-4835) Refactor template rendering functions

    [ https://issues.apache.org/jira/browse/AIRFLOW-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932577#comment-16932577 ] 

ASF subversion and git services commented on AIRFLOW-4835:
----------------------------------------------------------

Commit 6107622671c8f2633ea34957fd7719b30beb3bb7 in airflow's branch refs/heads/v1-10-test from Bas Harenslak
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=6107622 ]

[AIRFLOW-4835] Refactor operator render_template (#5461)

- Refactors `BaseOperator.render_template()` and removes `render_template_from_field()`. The functionality could be greatly simplified into a single `render_template()` function.
- Improves performance by removing two `hasattr` calls and avoiding recreating Jinja environments.
- Removes the argument `attr` to `render_template()` which wasn't used.
- Squashes multiple similar tests into two parameterized tests.
- Adheres to 110 line length.
- Adds support for templating sets.
- Adds Pydoc.
- Adds typing.

(cherry picked from commit 47dd4c99a7324cb52121a25001599d4e7597959b)


> Refactor template rendering functions
> -------------------------------------
>
>                 Key: AIRFLOW-4835
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4835
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 2.0.0
>            Reporter: Bas Harenslak
>            Priority: Major
>             Fix For: 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)